This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: IDLE - Fix several highlighting bugs
Type: Stage:
Components: IDLE Versions: Python 2.6, Python 2.5
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: kbk Nosy List: kbk, taleinat
Priority: normal Keywords: patch

Created on 2007-10-26 13:16 by taleinat, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
IDLE_highlighting.071028.patch taleinat, 2007-10-28 02:49
Messages (3)
msg56788 - (view) Author: Tal Einat (taleinat) * (Python committer) Date: 2007-10-26 13:16
This patch fixes the following bugs:

* Configured selection highlighting colors were ignored
* Updating highlighting in the config dialog would cause
  non-Python files to be colored as if they were Python source

Additionally, adding and removing of ColorDelegators to the Percolator
was not being done in an organized fashion, causing multiple colorizers
to be present simultaneously in certain cases. This patch ensures that
there will always be at most one colorizer present in the Percolator.

This patch also reduces code duplication by grouping colorization code
into EditorWindow.ResetColorizer, and having __init__ let ResetColorizer
do its thing.

There is one side effect to this patch - applying a new highlighting
scheme or renaming a file causes the screen to "blink". This can be
avoided without too much work, but IMHO is minor enough to leave as it is.
msg56875 - (view) Author: Tal Einat (taleinat) * (Python committer) Date: 2007-10-28 02:49
The first patch contained a bug - a window opened using the "New Window"
menu option would not be colorized.

This patch removes the assumption that EditorWindow.ResetColorizer will
be called by IOBinding code, by calling ResetColorizer during __init__
anyways. This means that in some cases it will be called multiple times,
but this has no noticeable effect since the window is not shown until
afterwards. (In the worst case scenario, the colors would "blink" once
or twice.)
msg62445 - (view) Author: Kurt B. Kaiser (kbk) * (Python committer) Date: 2008-02-15 22:25
r60844. Thanks for the patch!
History
Date User Action Args
2022-04-11 14:56:27adminsetgithub: 45675
2008-02-15 22:25:44kbksetstatus: open -> closed
resolution: accepted
messages: + msg62445
2008-02-15 22:19:34kbksetfiles: - IDLE_highlighting.071026.patch
2007-10-28 23:12:49kbksetkeywords: + patch
assignee: kbk
2007-10-28 02:49:25taleinatsetfiles: + IDLE_highlighting.071028.patch
messages: + msg56875
2007-10-26 13:16:09taleinatcreate