➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2007-10-19 22:59 by amaury.forgeotdarc, last changed 2022-04-11 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| win32build.diff | amaury.forgeotdarc, 2007-10-19 22:59 | |||
| win32build.2.diff | amaury.forgeotdarc, 2007-10-22 22:08 | |||
| Messages (4) | |||
|---|---|---|---|
| msg56573 - (view) | Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) *  |
Date: 2007-10-19 22:59 | |
This patch is needed to have py3k compile on win32, since the introduction of bytes_methods.c. Also, use the recently re-added md5module.c and sha1module.c, because a precompiled openssl library is difficult to obtain on Windows. Note: I tested only with VS2005. I will watch the buildbots to verify that compilation actually succeeds. |
|||
| msg56650 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2007-10-22 16:34 | |
This doesn't apply cleanly with today's trunk, and that's not just due to the fix by Christian Heimes (which I checked in before noticing this) that fixes the same issue (bytes_methods.c). Can you & Christian please work together on a new patch? I don't have Windows access but I will check it in if it applies cleanly. |
|||
| msg56660 - (view) | Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * |
Date: 2007-10-22 22:08 | |
I generated the file with "svn diff", on Windows. Is it a line ending issue in the diff file? Many text files have the svn:eol-style=native property, but the PCBuild8/*/*.vcproj don't. I upload a new version of the patch, with all line endings converted to Unix mode. It should match your local copy. |
|||
| msg56661 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2007-10-22 22:19 | |
Yup, I think that was it. Sorry. Committed revision 58597. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:27 | admin | set | github: 45645 |
| 2007-10-22 22:19:15 | gvanrossum | set | status: open -> closed resolution: accepted messages: + msg56661 |
| 2007-10-22 22:08:21 | amaury.forgeotdarc | set | files:
+ win32build.2.diff messages: + msg56660 |
| 2007-10-22 16:34:34 | gvanrossum | set | keywords:
+ patch nosy: + gvanrossum messages: + msg56650 |
| 2007-10-19 22:59:21 | amaury.forgeotdarc | create | |