classification
Title: expose signalfd(2) in the signal module
Type: Stage: patch review
Components: Extension Modules Versions: Python 3.3
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: exarkun, haypo, nadeem.vawda, neologix, rosslagerwall
Priority: normal Keywords: patch

Created on 2011-06-09 23:00 by haypo, last changed 2012-05-20 15:04 by rosslagerwall.

Files
File name Uploaded Description Edit
signalfd-4.patch haypo, 2011-06-09 23:02
Messages (4)
msg138034 - (view) Author: STINNER Victor (haypo) * (Python committer) Date: 2011-06-09 23:00
"Linux offers the signalfd syscall since 2.6.22 (with minor changes afterwards).  This call allows signals to be handled as bytes read out of a file descriptor, rather than as interruptions to the flow of a program.  Quite usefully, this file descriptor can be select()'d on (or poll()'d, epoll()'d, etc) alongside other "normal" file descriptors.

In order to effectively use signalfd(), the signals in question must be blocked, though.  So it makes sense to expose sigprocmask(2) at the same time, in order to allow this blocking to be set up."

This message is copy/pasted from #8407 (msg103182). I created the issue because #8407 contains much more than signalfd().
msg138035 - (view) Author: STINNER Victor (haypo) * (Python committer) Date: 2011-06-09 23:02
signalfd-4.patch: my more recent patch exposing signalfd(). It lacks a structure to decode the bytes read from the signalfd file descriptor. Example in ctypes (msg135438):

class signalfd_siginfo(Structure):
    _fields_ = (
        ('ssi_signo', c_uint32),    # Signal number
        ('ssi_errno', c_int32),     # Error number (unused)
        ('ssi_code', c_int32),      # Signal code
        ('ssi_pid', c_uint32),      # PID of sender
        ('ssi_uid', c_uint32),      # Real UID of sender
        ('ssi_fd', c_int32),        # File descriptor (SIGIO)
        ('ssi_tid', c_uint32),      # Kernel timer ID (POSIX timers)
        ('ssi_band', c_uint32),     # Band event (SIGIO)
        ('ssi_overrun', c_uint32),  # POSIX timer overrun count
        ('ssi_trapno', c_uint32),   # Trap number that caused signal
        ('ssi_status', c_int32),    # Exit status or signal (SIGCHLD)
        ('ssi_int', c_int32),       # Integer sent by sigqueue(2)
        ('ssi_ptr', c_uint64),      # Pointer sent by sigqueue(2)
        ('ssi_utime', c_uint64),    # User CPU time consumed (SIGCHLD)
        ('ssi_stime', c_uint64),    # System CPU time consumed (SIGCHLD)
        ('ssi_addr', c_uint64),     # Address that generated signal
                                    # (for hardware-generated signals)
        ('_padding', c_char * 46),  # Pad size to 128 bytes (allow for
                                    # additional fields in the future)
    )
msg138040 - (view) Author: STINNER Victor (haypo) * (Python committer) Date: 2011-06-09 23:40
#8407 changed the wakeup fd: it now contains the signal number. pthread_sigmask() is now part of Python 3.3 (see also #8407).

signalfd() has advantages over the wakeup fd (msg103326):

 - it is handled in the kernel, the process is not interrupted. For example, system calls cannot fail with EINTR.
 - it gives much more information than the signal number (see signalfd_siginfo structure)
 - it is also possible to have several signalfds, each with a different signal mask. set_wakeup_fd is limited to a single fd per-process.
msg161212 - (view) Author: Ross Lagerwall (rosslagerwall) (Python committer) Date: 2012-05-20 15:04
Patch seems good (although it doesn't apply cleanly).

Why do you not provide a structure to decode the bytes? I thought relying on ctypes in the stdlib was not advised...
History
Date User Action Args
2012-05-20 15:04:14rosslagerwallsetnosy: + rosslagerwall
messages: + msg161212
2012-05-16 15:56:23pitrousetnosy: + neologix

stage: patch review
2011-06-10 06:41:34nadeem.vawdasetnosy: + nadeem.vawda
2011-06-09 23:40:57hayposetmessages: + msg138040
2011-06-09 23:02:34hayposetfiles: + signalfd-4.patch
keywords: + patch
messages: + msg138035
2011-06-09 23:00:56haypocreate