➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2011-03-15 05:02 by beardedp, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| test_pulldom_resource_warning.patch | beardedp, 2011-03-15 05:33 | Patch to silence resource warning on the test_pulldom test. | review | |
| Messages (5) | |||
|---|---|---|---|
| msg130956 - (view) | Author: Ben Hayden (beardedp) * | Date: 2011-03-15 05:02 | |
When running the test_pulldom test with a latest checkout of cpython from hg.python.org on Ubuntu 10.10 x64, the following ResourceWarning is thrown: test_parse (test.test_pulldom.PullDOMTestCase) Minimal test of DOMEventStream.parse() ... /home/benhayden/Documents/cpython/Lib/test/test_pulldom.py:35: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/benhayden/Documents/cpython/Lib/test/xmltestdata/test.xml' mode='r' encoding='UTF-8'> list(pulldom.parse(tstfile)) ok This is because pulldom.parse returns an open file object if the argument it is passed is a string & not a file object. Attached is a patch that makes sure that file is closed. |
|||
| msg130969 - (view) | Author: Andreas Stührk (Trundle) * | Date: 2011-03-15 13:11 | |
Any reason why the patch removes the `list()` calls? Without them, no parsing happens at all. |
|||
| msg130975 - (view) | Author: Ben Hayden (beardedp) * | Date: 2011-03-15 14:01 | |
I was unclear as to why the list() calls were there. I thought it would just change the iterator into a list - I didn't know that actually was needed for the test - my mistake. I'll change it back to the list() - but I'll need to loop over the first list to make sure and close the stream. |
|||
| msg131038 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2011-03-15 21:23 | |
New changeset aa000dd4287f by Brett Cannon in branch 'default': Close a stream properly in test.test_pulldom. http://hg.python.org/cpython/rev/aa000dd4287f |
|||
| msg131039 - (view) | Author: Brett Cannon (brett.cannon) *  |
Date: 2011-03-15 21:24 | |
Fixed in [aa000dd4287f]. I went with a simpler solution than Ben's, but it did help figure out what to do. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:14 | admin | set | github: 55759 |
| 2011-03-15 21:24:52 | brett.cannon | set | status: open -> closed nosy: + brett.cannon messages: + msg131039 resolution: fixed stage: resolved |
| 2011-03-15 21:23:29 | python-dev | set | nosy:
+ python-dev messages: + msg131038 |
| 2011-03-15 20:20:17 | nadeem.vawda | set | nosy:
+ nadeem.vawda |
| 2011-03-15 14:01:37 | beardedp | set | messages: + msg130975 |
| 2011-03-15 13:11:55 | Trundle | set | nosy:
+ Trundle messages: + msg130969 |
| 2011-03-15 05:33:51 | beardedp | set | files:
+ test_pulldom_resource_warning.patch versions: - Python 3.3, Python 3.4 |
| 2011-03-15 05:33:24 | beardedp | set | files: - test_pulldom_resource_warning.patch |
| 2011-03-15 05:02:30 | beardedp | create | |