Created on 2011-02-18 22:12 by haypo, last changed 2011-03-01 22:49 by haypo. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue11246.diff | ysj.ray, 2011-02-22 03:55 | |||
| Messages (5) | |||
|---|---|---|---|
| msg128816 - (view) | Author: STINNER Victor (haypo) *  |
Date: 2011-02-18 22:12 | |
While testing a patch fixing issue #7330, I found a bug in PyUnicode_FromFormat() in the %V format: it decodes the byte string from ISO-8859-1, whereas I would expect that the string is decodes from UTF-8, as the "%s" format. |
|||
| msg128945 - (view) | Author: ysj.ray (ysj.ray) | Date: 2011-02-21 07:21 | |
Yes. The %V should be combination of %U and %s. Here is a patch which fixed this problem. |
|||
| msg128990 - (view) | Author: STINNER Victor (haypo) * |
Date: 2011-02-21 20:24 | |
+ text = PyUnicode_FromFormat(b'repr=%V', 'abcdef', b'abcdef')
+ self.assertEqual(text, 'repr=abcdef')
How do you know which argument is used? For example, you should use instead 'abc' and b'xyz'.
+ text = PyUnicode_FromFormat(b'repr=%V', None, '人民'.encode('UTF-8'))
+ self.assertEqual(text, 'repr=人民')
I prefer ASCII literals using \x or \u: '\xe4\xba\xe6\xb0\u2018'.
You should also add a test specific to the replace error handler, e.g. (None, b'abc\xff') => 'abc\ufffd'.
|
|||
| msg129033 - (view) | Author: ysj.ray (ysj.ray) | Date: 2011-02-22 03:55 | |
Thanks haypo! Here the updated patch, following your comments. |
|||
| msg129829 - (view) | Author: STINNER Victor (haypo) * |
Date: 2011-03-01 22:49 | |
Fixed in Python 3.3 (r88697) and 3.2 (r88698). Thank you Ray. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2011-03-01 22:49:08 | haypo | set | status: open -> closed messages: + msg129829 resolution: fixed nosy: haypo, ysj.ray |
| 2011-02-22 03:55:46 | ysj.ray | set | files:
- issue11246.diff nosy: haypo, ysj.ray |
| 2011-02-22 03:55:16 | ysj.ray | set | files:
+ issue11246.diff type: behavior messages: + msg129033 nosy: haypo, ysj.ray |
| 2011-02-21 20:24:19 | haypo | set | nosy:
haypo, ysj.ray messages: + msg128990 |
| 2011-02-21 07:22:33 | ysj.ray | set | files:
+ issue11246.diff nosy: haypo, ysj.ray keywords: + patch |
| 2011-02-21 07:21:45 | ysj.ray | set | nosy:
haypo, ysj.ray messages: + msg128945 |
| 2011-02-18 22:12:30 | haypo | set | nosy:
haypo, ysj.ray components: + Library (Lib) |
| 2011-02-18 22:12:10 | haypo | create | |