Created on 2010-12-03 01:25 by michael.foord, last changed 2010-12-19 15:00 by michael.foord. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue_10611.diff | ysj.ray, 2010-12-10 06:29 | patch against py3k | ||
| Messages (7) | |||
|---|---|---|---|
| msg123153 - (view) | Author: Michael Foord (michael.foord) *  |
Date: 2010-12-03 01:25 | |
Reported by a unittest2 user.
A SystemExit (or GeneratorExit) will cause a test run to stop in 2.7 / 3.2. This would just be reported as an error in 2.6.
>>> from unittest import TestCase
>>> def test(s):
... raise GeneratorExit
...
>>> class T(TestCase):
... test = test
...
>>> t = T('test')
>>> t.run()
Above code works in Python 2.6 (the exception is caught by TestCase.run) but dies in 2.7 / 3.2
|
|||
| msg123717 - (view) | Author: ysj.ray (ysj.ray) | Date: 2010-12-10 06:29 | |
Agreed. I think the "except Exception" in TestCase.run() should be "except BaseException", since BaseException could catch Exception, SystemExit, GeneratorExit, KeyboardInterrupt. The KeyboardInterrupt should be caught first. The remaining three is exactly what is needed. Here is a patch I worked, with unittest. |
|||
| msg123718 - (view) | Author: Éric Araujo (eric.araujo) * |
Date: 2010-12-10 07:15 | |
LGTM. |
|||
| msg123726 - (view) | Author: Michael Foord (michael.foord) * |
Date: 2010-12-10 10:43 | |
At the moment exception handling for setUp / tearDown / testMethod and cleanUp functions are all handled separately. They all have to call addError and as a result we have inconsistent handling of skips, expected failures (etc). There are separate issues for handling expected failures in setUp and skips in tearDown. I'd like to fix all these issues by moving the exception handling into a single method and unifying the reporting of failure / error / expected failure / skip test. This will fix all these issues and nicely simplify the implementation. |
|||
| msg124110 - (view) | Author: ysj.ray (ysj.ray) | Date: 2010-12-16 07:38 | |
> I'd like to fix all these issues by moving the exception handling into a single method and unifying the reporting of failure / error / expected failure / skip test. This will fix all these issues and nicely simplify the implementation. That sounds good. |
|||
| msg124356 - (view) | Author: Michael Foord (michael.foord) * |
Date: 2010-12-19 14:56 | |
Committed to Python 2.7 in revision 87406. |
|||
| msg124357 - (view) | Author: Michael Foord (michael.foord) * |
Date: 2010-12-19 15:00 | |
Committed to py3k in revision 87390. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2010-12-19 15:00:23 | michael.foord | set | nosy:
eric.araujo, michael.foord, ysj.ray messages: + msg124357 |
| 2010-12-19 14:56:28 | michael.foord | set | status: open -> closed nosy: eric.araujo, michael.foord, ysj.ray messages: + msg124356 resolution: fixed stage: patch review -> committed/rejected |
| 2010-12-16 07:38:25 | ysj.ray | set | nosy:
eric.araujo, michael.foord, ysj.ray messages: + msg124110 |
| 2010-12-10 10:43:09 | michael.foord | set | messages: + msg123726 |
| 2010-12-10 07:15:58 | eric.araujo | set | messages:
+ msg123718 stage: test needed -> patch review |
| 2010-12-10 06:29:03 | ysj.ray | set | files:
+ issue_10611.diff nosy: + ysj.ray messages: + msg123717 keywords: + patch |
| 2010-12-03 01:34:17 | eric.araujo | set | nosy:
+ eric.araujo |
| 2010-12-03 01:25:34 | michael.foord | set | title: sys.exit() in a test causes the run to stp -> sys.exit() in a test causes a test run to die |
| 2010-12-03 01:25:17 | michael.foord | create | |