➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2010-11-22 10:01 by gz, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue9981_regression.patch | gz, 2010-11-22 10:01 | Patch sprinkling quotes around the place | review | |
| Messages (7) | |||
|---|---|---|---|
| msg122104 - (view) | Author: Martin (gz) * | Date: 2010-11-22 10:01 | |
My build got broken by the change for issue 9981 in revision 86137. The problem is it adds $(IntDir) to various places in the vcproj file, including the command line arguments to make_buildinfo, and my svn checkout is under a dir with a space in. Ideally it could just use a relative path, but just making sure it's quoted works too. |
|||
| msg122109 - (view) | Author: Martin v. Löwis (loewis) *  |
Date: 2010-11-22 11:07 | |
Kristjan, can you take a look? |
|||
| msg122113 - (view) | Author: Kristján Valur Jónsson (kristjan.jonsson) * |
Date: 2010-11-22 11:38 | |
Ah yes, spaces in filenames. One always forgets. Fixed the make_buildinfo.c (quote whole string, not just part of it) and committed in revision 86689 |
|||
| msg122172 - (view) | Author: Martin (gz) * | Date: 2010-11-22 22:34 | |
Thanks. Don't actually need to quote the whole path, but what you've landed works for me. |
|||
| msg122185 - (view) | Author: Kristján Valur Jónsson (kristjan.jonsson) * |
Date: 2010-11-23 01:45 | |
I did various tests and quoting parts of the path seemed fragile, especially if the quote landed next to a backslash. This is dangerous ground :) |
|||
| msg127255 - (view) | Author: Eli Bendersky (eli.bendersky) * |
Date: 2011-01-28 08:33 | |
Please see issue 11034 |
|||
| msg401523 - (view) | Author: Irit Katriel (iritkatriel) * |
Date: 2021-09-09 21:59 | |
There is no longer a make_buildinfo.c |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:09 | admin | set | github: 54710 |
| 2021-09-09 21:59:07 | iritkatriel | set | status: open -> closed nosy: + iritkatriel messages: + msg401523 resolution: accepted -> out of date stage: resolved |
| 2011-11-12 05:08:44 | eli.bendersky | set | nosy:
- eli.bendersky |
| 2011-01-28 08:33:47 | eli.bendersky | set | status: closed -> open nosy: + eli.bendersky messages: + msg127255 |
| 2010-11-23 01:45:45 | kristjan.jonsson | set | messages: + msg122185 |
| 2010-11-22 22:34:14 | gz | set | messages: + msg122172 |
| 2010-11-22 11:38:20 | kristjan.jonsson | set | status: open -> closed resolution: accepted messages: + msg122113 |
| 2010-11-22 11:07:39 | loewis | set | assignee: kristjan.jonsson messages: + msg122109 nosy: + loewis |
| 2010-11-22 10:01:41 | gz | create | |