Issue1034
Created on 2007-08-27 02:20 by adrianholovaty, last changed 2008-09-12 23:11 by benjamin.peterson.
|
|
msg55331 - (view) |
Author: Adrian Holovaty (adrianholovaty) |
Date: 2007-08-27 02:20 |
|
Per a Python-3000 mailing list discussion here --
http://mail.python.org/pipermail/python-3000/2007-August/009835.html --
I have implemented an addition to the 2to3 utility that enables warnings
to be output as comments in Python source code instead of being logged
to stdout.
See the attached patch and a description of the changes here:
http://mail.python.org/pipermail/python-3000/2007-August/009881.html
|
|
msg55332 - (view) |
Author: Adrian Holovaty (adrianholovaty) |
Date: 2007-08-27 02:21 |
|
I'm also attaching 2to3_comment_warnings.diff, which is an example of
how we could integrate the insert_comment() method from the first patch
to replace the current functionality of fixes.basefix.BaseFix.warning().
|
|
msg73152 - (view) |
Author: Benjamin Peterson (benjamin.peterson) |
Date: 2008-09-12 23:11 |
|
On the patch:
1. I think both a log message and the comment should be written. The
point needs to be reinforced to users.
2. I'd like to see some tests.
3. Maybe an option to turn the auto comments off?
This is interesting. I'd like to have someone else weigh in before it is
applied though.
|
|
| Date |
User |
Action |
Args |
| 2008-09-12 23:11:06 | benjamin.peterson | set | nosy:
+ benjamin.peterson
messages:
+ msg73152 |
| 2008-01-06 22:29:44 | admin | set | keywords:
- py3k
versions:
Python 3.0 |
| 2007-11-23 08:27:36 | christian.heimes | set | keywords:
+ py3k
versions:
+ Python 3.0 |
| 2007-09-17 08:26:29 | jafo | set | priority: normal |
| 2007-09-06 17:58:56 | collinwinter | set | assignee: collinwinter
components:
+ 2to3 (2.x to 3.0 conversion tool), - Demos and Tools
nosy:
+ collinwinter |
| 2007-09-02 20:09:16 | loewis | set | keywords:
+ patch |
| 2007-08-27 02:21:54 | adrianholovaty | set | files:
+ 2to3_comment_warnings.diff
messages:
+ msg55332 |
| 2007-08-27 02:20:52 | adrianholovaty | create | |
|
