Issue1019
Created on 2007-08-25 11:25 by larry, last changed 2008-01-13 23:43 by akuchling.
|
|
msg55287 - (view) |
Author: Larry Hastings (larry) |
Date: 2007-08-25 11:25 |
|
*BEFORE* APPLYING THIS PATCH, YOU MUST
% svn move Include/py_curses.h Modules/_py_curses.h
(A "patch" can't convey that sort of information.)
I made a pass cleaning up _curses and _curses_panel. Mainly I cleaned
up the header file, moving unnecessary things into the two .c files.
I also changed the way information is passed from _curses to
_curses_panel. Instead of a Py_CObject which points to functions--which
Neil Norwitz suspected could be a security hole--it now passes cleaner
information (one type, one int * pointer). Finally, I made a
code-cleanup pass as per PEP 7.
|
|
msg55435 - (view) |
Author: Guido van Rossum (gvanrossum) |
Date: 2007-08-29 20:40 |
|
I tried to run the various demos in Demo/curses/ with the new version.
They all work except for xmas.py. Before your patch, they all ran.
So I cannot apply this yet. (No time to look into it further, alas.)
|
|
msg55866 - (view) |
Author: Georg Brandl (georg.brandl) |
Date: 2007-09-12 19:36 |
|
Unfortunately, the patch is hard to review with all the whitespace
cleanup distracting from semantic changes. Can you produce a patch with
only those changes?
|
|
| Date |
User |
Action |
Args |
| 2008-01-13 23:43:33 | akuchling | set | assignee: akuchling -> |
| 2008-01-12 01:17:28 | akuchling | set | assignee: akuchling
nosy:
+ akuchling |
| 2007-09-17 10:52:19 | jafo | set | priority: low |
| 2007-09-12 19:36:08 | georg.brandl | set | nosy:
+ georg.brandl
messages:
+ msg55866 |
| 2007-09-02 20:08:07 | loewis | set | keywords:
+ patch |
| 2007-08-29 20:40:27 | gvanrossum | set | nosy:
+ gvanrossum
messages:
+ msg55435 |
| 2007-08-25 11:25:16 | larryhastings | create | |
|
