Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31615)

#9951: introduce bytes.hex method (also for bytearray and memoryview)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by wiggin15
Modified:
4 years, 2 months ago
Reviewers:
ncoghlan, eric
CC:
lemburg, barry, Georg, rhettinger, terry.reedy, gregory.p.smith, mark.dickinson, Nick Coghlan, AntoinePitrou, eric.smith, chris.lasher_gmail.com, christian.heimes, eric.araujo, Arfrever, BreamoreBoy, stoneleaf, wiggin15, devnull_psf.upfronthosting.co.za, Martin Panter, storchaka, hctamtb_gmail.com
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/stdtypes.rst View 1 2 3 chunks +37 lines, -0 lines 0 comments Download
Include/pystrhex.h View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
Lib/test/test_bytes.py View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
Lib/test/test_doctest.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
Makefile.pre.in View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
Modules/sha1module.c View 1 2 2 chunks +2 lines, -21 lines 0 comments Download
Modules/sha256module.c View 1 2 2 chunks +2 lines, -21 lines 0 comments Download
Modules/sha512module.c View 1 2 2 chunks +2 lines, -21 lines 0 comments Download
Objects/bytearrayobject.c View 1 2 3 chunks +15 lines, -0 lines 0 comments Download
Objects/bytesobject.c View 1 2 3 chunks +16 lines, -0 lines 0 comments Download
Objects/memoryobject.c View 1 2 4 chunks +14 lines, -0 lines 0 comments Download
PCbuild/pythoncore.vcxproj View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
PCbuild/pythoncore.vcxproj.filters View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
Python/pystrhex.c View 1 2 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Nick Coghlan
The structure of the change itself looks good to me, just one comment on a ...
4 years, 2 months ago #1
Nick Coghlan
After applying it locally, I noticed that pystrhex.h and pystrhex.c are currently missing from the ...
4 years, 2 months ago #2
eric.smith
4 years, 2 months ago #3
A small nit. I have not had time to give this a proper review. I'll try and do
that after I get home.

https://bugs.python.org/review/9951/diff/14535/Lib/test/test_bytes.py
File Lib/test/test_bytes.py (right):

https://bugs.python.org/review/9951/diff/14535/Lib/test/test_bytes.py#newcode310
Lib/test/test_bytes.py:310: self.assertEquals(memoryview(b"\x1a\x2b\x30").hex(),
'1a2b30')
Also, these should be .assertEqual, not .assertEquals.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+