Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(94800)

#9949: os.path.realpath on Windows does not follow symbolic links

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 5 months ago by stutzbach
Modified:
3 years, 11 months ago
Reviewers:
takowl, zachary.ware, dharding, eryksun
CC:
pmoore, ishimoto, jaraco, AntoinePitrou, haypo, eric.smith, tim.golden, stutzbach, Daniel Harding, Thomas Kluyver, Zach Ware, ncdave4life_gmail.com, eryksun, steve.dower, chrak533_gmail.com, ethan_ethanhs.me, pablogsal, svart.riddare_gmail.com, mariatta.wijaya+miss-islington_gmail.com
Visibility:
Public.

Patch Set 1 #

Total comments: 13

Patch Set 2 #

Patch Set 3 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/os.path.rst View 1 2 1 chunk +4 lines, -1 line 0 comments Download
Lib/ntpath.py View 1 2 2 chunks +115 lines, -19 lines 0 comments Download
Lib/test/test_ntpath.py View 1 2 3 chunks +165 lines, -1 line 0 comments Download
Lib/test/test_os.py View 1 2 1 chunk +1 line, -4 lines 0 comments Download
Modules/posixmodule.c View 1 2 6 chunks +124 lines, -74 lines 1 comment Download

Messages

Total messages: 6
takowl_gmail.com
http://bugs.python.org/review/9949/diff/5077/Lib/ntpath.py File Lib/ntpath.py (right): http://bugs.python.org/review/9949/diff/5077/Lib/ntpath.py#newcode706 Lib/ntpath.py:706: realpath = normpath(abspath) It looks like this is calling ...
5 years, 1 month ago #1
Zach Ware
Everything outside of ntpath.py is beyond the scope of this issue. From what I gathered ...
5 years, 1 month ago #2
dharding_gmail.com
On 2014/10/11 07:31:03, Zach Ware wrote: > Everything outside of ntpath.py is beyond the scope ...
4 years, 9 months ago #3
dharding_gmail.com
http://bugs.python.org/review/9949/diff/5077/Lib/ntpath.py File Lib/ntpath.py (right): http://bugs.python.org/review/9949/diff/5077/Lib/ntpath.py#newcode647 Lib/ntpath.py:647: def realpath(path): On 2014/10/11 07:31:03, Zach Ware wrote: > ...
4 years, 9 months ago #4
Zach Ware
http://bugs.python.org/review/9949/diff/5077/Lib/ntpath.py File Lib/ntpath.py (right): http://bugs.python.org/review/9949/diff/5077/Lib/ntpath.py#newcode652 Lib/ntpath.py:652: if not isinstance(path, str): On 2015/02/04 14:13:03, Daniel Harding ...
4 years, 9 months ago #5
eryksun
3 years, 11 months ago #6
http://bugs.python.org/review/9949/diff/13878/Modules/posixmodule.c
File Modules/posixmodule.c (right):

http://bugs.python.org/review/9949/diff/13878/Modules/posixmodule.c#newcode10154
Modules/posixmodule.c:10154: if (rdb->ReparseTag != IO_REPARSE_TAG_SYMLINK)
This should support IO_REPARSE_TAG_MOUNT_POINT (i.e. junction). It's used for
mounting a volume in an NTFS directory, but it's also commonly used to link to a
directory on a local volume. The data buffer is specified in [MS-FSCC] (file
system control codes) section 2.1.2.5, but we already have it defined in
REPARSE_DATA_BUFFER as MountPointReparseBuffer.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+