Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83474)

#9556: Specifying the time a TimedRotatingFileHandler rotates

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by ronaldoussoren
Modified:
7 years ago
Reviewers:
CC:
Vinay Sajip, Ronald Oussoren, eric.araujo, tshepang, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 2

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/logging.handlers.rst View 1 2 2 chunks +7 lines, -1 line 0 comments Download
Lib/logging/handlers.py View 1 2 4 chunks +20 lines, -5 lines 0 comments Download
Lib/test/test_logging.py View 1 2 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 1
Ronald Oussoren
7 years ago #1
I won't have time to update the patch today, should have some time on friday.

Ronald

http://bugs.python.org/review/9556/diff/6365/Doc/library/logging.handlers.rst
File Doc/library/logging.handlers.rst (right):

http://bugs.python.org/review/9556/diff/6365/Doc/library/logging.handlers.rst...
Doc/library/logging.handlers.rst:345: If *atTime* is not ``None``, it must be a
``datetime.datetime`` instance
"datetime.datetime" should be "datetime.time"

http://bugs.python.org/review/9556/diff/6365/Lib/test/test_logging.py
File Lib/test/test_logging.py (right):

http://bugs.python.org/review/9556/diff/6365/Lib/test/test_logging.py#newcode...
Lib/test/test_logging.py:3869: self.assertEqual(actual, expected)
I'd also add a check for computeRollover where the current time is after the
rollover time (similar to test_compute_rollover_daily_attime)
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+