Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

#9517: Make test.script_helper more comprehensive, and use it in the test suite

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by pitrou
Modified:
4 years, 9 months ago
Reviewers:
berker.peksag, bobcatfish
CC:
Nick Coghlan, AntoinePitrou, ezio.melotti, r.david.murray, Michael Foord, rodriguealcazar_gmail.com, devnull_psf.upfronthosting.co.za, berkerpeksag, storchaka, christie, flipmcf_gmail.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 2

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/script_helper.py View 1 2 3 1 chunk +0 lines, -244 lines 0 comments Download
Lib/test/support/script_helper.py View 1 2 3 1 chunk +241 lines, -0 lines 0 comments Download
Lib/test/test_asyncio/test_base_events.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_asyncio/test_tasks.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_builtin.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_calendar.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_capi.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_cgitb.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
Lib/test/test_cmd_line.py View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
Lib/test/test_cmd_line_script.py View 1 2 3 16 chunks +23 lines, -24 lines 0 comments Download
Lib/test/test_compileall.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
Lib/test/test_concurrent_futures.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_crashers.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_doctest.py View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
Lib/test/test_eintr.py View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
Lib/test/test_faulthandler.py View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
Lib/test/test_gc.py View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
Lib/test/test_hash.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_import/__init__.py View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
Lib/test/test_inspect.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_io.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_json/test_tool.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_logging.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_module.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_multiprocessing_main_handling.py View 1 2 3 10 chunks +15 lines, -16 lines 0 comments Download
Lib/test/_test_multiprocessing.py View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
Lib/test/test_os.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_parser.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_pydoc.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_readline.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_runpy.py View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
Lib/test/test_script_helper.py View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
Lib/test/test_signal.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_subprocess.py View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
Lib/test/test_sys.py View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
Lib/test/test_tarfile.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
Lib/test/test_tempfile.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
Lib/test/test_threading.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_tools/test_md5sum.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_tools/test_pindent.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_tools/test_reindent.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_traceback.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_tracemalloc.py View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
Lib/test/test_warnings.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_weakref.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
Lib/test/test_zipimport_support.py View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2
berkerpeksag
http://bugs.python.org/review/9517/diff/14708/Lib/test/test_faulthandler.py File Lib/test/test_faulthandler.py (right): http://bugs.python.org/review/9517/diff/14708/Lib/test/test_faulthandler.py#newcode11 Lib/test/test_faulthandler.py:11: from test.support.script_helper import assert_python_ok Instead of importing assert_python_ok separately, ...
4 years, 9 months ago #1
christie
4 years, 9 months ago #2
> Instead of importing assert_python_ok separately, can you change the
> assert_python_ok usage to script_helper.assert_python_ok?

Heh, actually as it turns out this is unused! I'll just remove the import
completely
 
> We can import interpreter_requires_environment above.

Okee dokee!
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+