Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(23435)

#9372: pulldom.DOMEventStream.__getitem__ is broken

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by mark.smith
Modified:
3 years, 8 months ago
Reviewers:
vadmium+py, storchaka
CC:
eric.araujo, mark.smith_practicalpoetry.co.uk, berkerpeksag, Martin Panter, storchaka, Thomas Fenzl
Visibility:
Public.

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_pulldom.py View 2 chunks +8 lines, -4 lines 1 comment Download
Lib/xml/dom/pulldom.py View 8 chunks +11 lines, -0 lines 4 comments Download

Messages

Total messages: 2
Martin Panter
https://bugs.python.org/review/9372/diff/7662/Lib/test/test_pulldom.py File Lib/test/test_pulldom.py (right): https://bugs.python.org/review/9372/diff/7662/Lib/test/test_pulldom.py#newcode347 Lib/test/test_pulldom.py:347: warn.assert_called_once_with(mock.ANY, DeprecationWarning) Perhaps it would be simpler to use ...
3 years, 8 months ago #1
storchaka_gmail.com
3 years, 8 months ago #2
https://bugs.python.org/review/9372/diff/7662/Lib/xml/dom/pulldom.py
File Lib/xml/dom/pulldom.py (right):

https://bugs.python.org/review/9372/diff/7662/Lib/xml/dom/pulldom.py#newcode3
Lib/xml/dom/pulldom.py:3: import warnings
Move import into __getitem__. It is never imported in normal case.

https://bugs.python.org/review/9372/diff/7662/Lib/xml/dom/pulldom.py#newcode227
Lib/xml/dom/pulldom.py:227: DeprecationWarning)
Add stacklevel=2.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+