Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12491)

#8232: webbrowser.open incomplete on Windows

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by joncwchao
Modified:
4 years ago
Reviewers:
steve.dower
CC:
Arfrever, r.david.murray, joncwchao_gmail.com, devplayer_gmail.com, devnull_psf.upfronthosting.co.za, eryksun, steve.dower, jbmilam, bostjan.xperia_gmail.com, Mariatta
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Total comments: 5

Patch Set 6 #

Total comments: 1

Patch Set 7 #

Patch Set 8 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/webbrowser.py View 1 2 3 4 5 6 7 2 chunks +118 lines, -9 lines 0 comments Download
Misc/NEWS View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
Modules/posixmodule.c View 1 2 3 4 5 6 7 5 chunks +25 lines, -6 lines 0 comments Download

Messages

Total messages: 2
steve.dower_microsoft.com
http://bugs.python.org/review/8232/diff/14999/Lib/webbrowser.py File Lib/webbrowser.py (right): http://bugs.python.org/review/8232/diff/14999/Lib/webbrowser.py#newcode506 Lib/webbrowser.py:506: key64 = winreg.OpenKey(HKLM, subkey, access=read64) Would rather see these ...
4 years, 3 months ago #1
steve.dower_microsoft.com
4 years, 3 months ago #2
http://bugs.python.org/review/8232/diff/15027/Lib/webbrowser.py
File Lib/webbrowser.py (right):

http://bugs.python.org/review/8232/diff/15027/Lib/webbrowser.py#newcode592
Lib/webbrowser.py:592: browsers += [winreg.EnumKey(key64,i)]
Do we always get the same number of browsers registered in 32-bit and 64-bit
keys? I think these need to be in separate loops. (Also, you can use
`browsers.append(...)` rather than += here.)
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+