Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29163)

#7159: Urllib2 authentication memory.

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by brado
Modified:
4 years, 6 months ago
Reviewers:
rdmurray, axitkhurana
CC:
terry.reedy, orsenthil, dstanek_dstanek.com, r.david.murray, cvrebert, brado_movedbylight.com, BreamoreBoy, devnull_psf.upfronthosting.co.za, axitkhurana, Martin Panter, marielle_gmail.com
Visibility:
Public.

Patch Set 1 #

Total comments: 7

Patch Set 2 #

Patch Set 3 #

Total comments: 2

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_urllib2.py View 1 2 3 4 chunks +88 lines, -16 lines 0 comments Download
Lib/urllib/request.py View 1 2 3 4 chunks +60 lines, -18 lines 0 comments Download

Messages

Total messages: 3
r.david.murray
http://bugs.python.org/review/7159/diff/14603/Lib/test/test_urllib2.py File Lib/test/test_urllib2.py (right): http://bugs.python.org/review/7159/diff/14603/Lib/test/test_urllib2.py#newcode17 Lib/test/test_urllib2.py:17: ) This is not our normal style for this. ...
4 years, 6 months ago #1
axitkhurana
https://bugs.python.org/review/7159/diff/14603/Lib/urllib/request.py File Lib/urllib/request.py (right): https://bugs.python.org/review/7159/diff/14603/Lib/urllib/request.py#newcode961 Lib/urllib/request.py:961: user, passwd = self.passwd.find_user_password(None, req.full_url) On 2015/04/16 01:36:20, r.david.murray ...
4 years, 6 months ago #2
axitkhurana
4 years, 6 months ago #3
https://bugs.python.org/review/7159/diff/14627/Doc/library/urllib.request.rst
File Doc/library/urllib.request.rst (right):

https://bugs.python.org/review/7159/diff/14627/Doc/library/urllib.request.rst...
Doc/library/urllib.request.rst:289: database of ``(realm, uri) ->
(is_authenticated)`` mappings.  Used with
Does not store (realm, uri) anymore. It's a (uri) -> (is_authenticated) mapping
now. realm is assumed None (default)

https://bugs.python.org/review/7159/diff/14627/Doc/library/urllib.request.rst...
Doc/library/urllib.request.rst:315: .. versionadded:: 3.5: added
``is_authenticated`` support.
Perfect
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+