Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(34148)

#6584: gzip module has no custom exception

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by sridharr
Modified:
6 years, 10 months ago
Reviewers:
ezio.melotti, tjreedy, merwok, storchaka
CC:
terry.reedy, AntoinePitrou, dstanek_dstanek.com, ezio.melotti, eric.araujo, gruszczy, srid, maker, storchaka, ZackerySpytz
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 7

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/gzip.rst View 1 2 3 4 5 1 chunk +4 lines, -0 lines 1 comment Download
Doc/whatsnew/3.4.rst View 1 2 3 4 5 1 chunk +1 line, -1 line 2 comments Download
Lib/gzip.py View 1 2 3 4 5 4 chunks +12 lines, -6 lines 0 comments Download
Lib/test/test_gzip.py View 1 2 3 4 5 1 chunk +11 lines, -0 lines 1 comment Download

Messages

Total messages: 7
ezio.melotti
http://bugs.python.org/review/6584/diff/2125/4259 File Lib/gzip.py (right): http://bugs.python.org/review/6584/diff/2125/4259#newcode106 Lib/gzip.py:106: Exception raised if processed file seems not to be ...
8 years, 6 months ago #1
terry.reedy
http://bugs.python.org/review/6584/diff/2125/4259 File Lib/gzip.py (right): http://bugs.python.org/review/6584/diff/2125/4259#newcode106 Lib/gzip.py:106: Exception raised if processed file seems not to be ...
8 years, 3 months ago #2
eric.araujo
http://bugs.python.org/review/6584/diff/2125/4259 File Lib/gzip.py (right): http://bugs.python.org/review/6584/diff/2125/4259#newcode443 Lib/gzip.py:443: hex(self.crc))) There is probably a string format code that ...
8 years, 1 month ago #3
ezio.melotti
http://bugs.python.org/review/6584/diff/2125/4259 File Lib/gzip.py (right): http://bugs.python.org/review/6584/diff/2125/4259#newcode443 Lib/gzip.py:443: hex(self.crc))) On 2011/08/20 23:16:35, eric.araujo wrote: > There is ...
8 years, 1 month ago #4
eric.araujo
> The difference between %x and hex() is that the latter includes the > 0x, ...
8 years, 1 month ago #5
storchaka_gmail.com
http://bugs.python.org/review/6584/diff/6547/Doc/library/gzip.rst File Doc/library/gzip.rst (right): http://bugs.python.org/review/6584/diff/6547/Doc/library/gzip.rst#newcode57 Doc/library/gzip.rst:57: .. class:: BadGzipfile BadGzipFile. http://bugs.python.org/review/6584/diff/6547/Doc/whatsnew/3.4.rst File Doc/whatsnew/3.4.rst (right): http://bugs.python.org/review/6584/diff/6547/Doc/whatsnew/3.4.rst#newcode152 ...
6 years, 10 months ago #6
eric.araujo
6 years, 10 months ago #7
http://bugs.python.org/review/6584/diff/6547/Doc/whatsnew/3.4.rst
File Doc/whatsnew/3.4.rst (right):

http://bugs.python.org/review/6584/diff/6547/Doc/whatsnew/3.4.rst#newcode152
Doc/whatsnew/3.4.rst:152: * The :module:`gzip` module throws a specific
:class:`BadGzipFile` in case of invalid or corrupted files.
throw is a generator method; please use “raise” here.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+