Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5107)

#5309: distutils doesn't parallelize extension module compilation

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by pitrou
Modified:
4 years, 6 months ago
Reviewers:
brad.froehle
CC:
AntoinePitrou, scoder, haypo, giampaolo.rodola, christian.heimes, tarek_ziade.org, eric.araujo, Arfrever, devnull_psf.upfronthosting.co.za, jtaylor, berkerpeksag, bfroehle, jonas.wagner_epfl.ch
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Patch Set 7 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/whatsnew/3.5.rst View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2
bfroehle
http://bugs.python.org/review/5309/diff/9715/Lib/distutils/command/build_ext.py File Lib/distutils/command/build_ext.py (right): http://bugs.python.org/review/5309/diff/9715/Lib/distutils/command/build_ext.py#newcode464 Lib/distutils/command/build_ext.py:464: self._build_extensions_serial() I think you want a return statement here ...
5 years, 9 months ago #1
AntoinePitrou
5 years, 9 months ago #2
http://bugs.python.org/review/5309/diff/9715/Lib/distutils/command/build_ext.py
File Lib/distutils/command/build_ext.py (right):

http://bugs.python.org/review/5309/diff/9715/Lib/distutils/command/build_ext....
Lib/distutils/command/build_ext.py:464: self._build_extensions_serial()
On 2013/10/26 22:28:22, bfroehle wrote:
> I think you want a return statement here so this doesn't fall through.

Indeed, good catch.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+