Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(129196)

#4972: context managerment support in imaplib, smtplib, ftplib

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by tarek
Modified:
5 years, 4 months ago
Reviewers:
ezio.melotti, storchaka
CC:
sasha, AntoinePitrou, giampaolo.rodola, tarek_ziade.org, ezio.melotti, eric.araujo, r.david.murray, stu.axon_gmail.com, SilentGhost, berkerpeksag, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/imaplib.rst View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
Doc/whatsnew/3.5.rst View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
Lib/imaplib.py View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
Lib/test/test_imaplib.py View 1 2 3 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 2
ezio.melotti
http://bugs.python.org/review/4972/diff/7228/Lib/test/test_imaplib.py File Lib/test/test_imaplib.py (right): http://bugs.python.org/review/4972/diff/7228/Lib/test/test_imaplib.py#newcode243 Lib/test/test_imaplib.py:243: imap.logout() Shouldn't there be some asserts that check that ...
6 years, 9 months ago #1
storchaka_gmail.com
6 years, 9 months ago #2
http://bugs.python.org/review/4972/diff/7228/Lib/test/test_imaplib.py
File Lib/test/test_imaplib.py (right):

http://bugs.python.org/review/4972/diff/7228/Lib/test/test_imaplib.py#newcode243
Lib/test/test_imaplib.py:243: imap.logout()
On 2013/01/27 17:53:12, ezio.melotti wrote:
> Shouldn't there be some asserts that check that after the 'with' the logout
> really happened in these tests?

Good idea.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+