Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(267529)

#4331: Can't use _functools.partial() created function as method

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 5 months ago by ssadler
Modified:
5 years, 9 months ago
Reviewers:
ncoghlan
CC:
rhettinger, jcea, Nick Coghlan, belopols_me.com, ironfroggy_users.sourceforge.net, jackdied, Christophe Simonis, ssadler_mashi.org, ulrich.eckhardt_dominolaser.com, r.david.murray, sasha, alonho, devnull_psf.upfronthosting.co.za, vajrasky
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 1

Patch Set 3 #

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/functools.rst View 1 2 3 2 chunks +42 lines, -1 line 0 comments Download
Doc/whatsnew/3.4.rst View 1 2 3 1 chunk +19 lines, -1 line 0 comments Download
Lib/functools.py View 1 2 3 3 chunks +76 lines, -2 lines 0 comments Download
Lib/test/test_functools.py View 1 2 3 3 chunks +116 lines, -0 lines 0 comments Download

Messages

Total messages: 1
Nick Coghlan
5 years, 9 months ago #1
This looks good to me - I can tweak the wording of the docs before checking it
in to emphasise the fact it's a non-callable descriptor like classmethod and
staticmethod.

http://bugs.python.org/review/4331/diff/9741/Lib/test/test_functools.py
File Lib/test/test_functools.py (right):

http://bugs.python.org/review/4331/diff/9741/Lib/test/test_functools.py#newco...
Lib/test/test_functools.py:1513: __metaclass__ = abc.ABCMeta
For Python 3.4+, this works:

    class Abstract(abc.ABC):
        ...
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+