Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1161)

#433028: SRE: (?flag:...) is not supported

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by fredrik
Modified:
1 year, 1 month ago
Reviewers:
ghost.adh, storchaka+cpython
CC:
fredrik_effbot.org, timehorse_users.sourceforge.net, ezio.melotti, mrabarnett, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/re.rst View 1 2 1 chunk +10 lines, -0 lines 2 comments Download
Doc/whatsnew/3.6.rst View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
Lib/re.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
Lib/sre_compile.py View 1 2 7 chunks +38 lines, -31 lines 0 comments Download
Lib/sre_parse.py View 1 2 13 chunks +84 lines, -30 lines 2 comments Download
Lib/test/test_re.py View 1 2 4 chunks +36 lines, -4 lines 0 comments Download
Misc/NEWS View 1 2 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 2
SilentGhost
Tested the patch, everything seems fine. https://bugs.python.org/review/433028/diff/18393/Doc/library/re.rst File Doc/library/re.rst (right): https://bugs.python.org/review/433028/diff/18393/Doc/library/re.rst#newcode248 Doc/library/re.rst:248: .. versionadded: 3.7 ...
1 year, 1 month ago #1
storchaka
1 year, 1 month ago #2
Thank you for your review SilentGhost.

https://bugs.python.org/review/433028/diff/18393/Doc/library/re.rst
File Doc/library/re.rst (right):

https://bugs.python.org/review/433028/diff/18393/Doc/library/re.rst#newcode248
Doc/library/re.rst:248: .. versionadded: 3.7
On 2016/09/07 20:34:47, SilentGhost wrote:
> Shouldn't this be 3.6?

Good catch!

https://bugs.python.org/review/433028/diff/18393/Lib/sre_parse.py
File Lib/sre_parse.py (right):

https://bugs.python.org/review/433028/diff/18393/Lib/sre_parse.py#newcode774
Lib/sre_parse.py:774: while True:
On 2016/09/07 20:34:47, SilentGhost wrote:
> This and the while loop below are very similar, perhaps it's worth abstracting
> them into a small sub-function?

Loops are similar, but there are many small differences (in particular different
error messages). It is possible to extract both loops in a sub-function, but
with all special cases it would be not so small.

https://bugs.python.org/review/433028/diff/18393/Misc/NEWS
File Misc/NEWS (right):

https://bugs.python.org/review/433028/diff/18393/Misc/NEWS#newcode94
Misc/NEWS:94: - Issue #433028: Added support of modifier spans in regular
expressions.
On 2016/09/07 20:34:47, SilentGhost wrote:
> support for

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7