Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7019)

#3566: httplib persistent connections violate MUST in RFC2616 sec 8.1.4.

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by cscott
Modified:
3 years, 10 months ago
Reviewers:
demianbrecht, rdmurray, vadmium+py
CC:
jeremy_alum.mit.edu, mhammond, jcea, orsenthil, python-dev_xhaus.com, rbcollins, cscott_cscott.net, r.david.murray, alan.justino_yahoo.com.br, agriffis_n01se.net, devnull_psf.upfronthosting.co.za, berkerpeksag, Martin Panter, icordasc, demian, baltazar.bz_gmail.com
Visibility:
Public.

Patch Set 1 #

Total comments: 6

Patch Set 2 #

Total comments: 10

Patch Set 3 #

Total comments: 4

Patch Set 4 #

Total comments: 6

Patch Set 5 #

Patch Set 6 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/http.client.rst View 1 2 3 4 5 3 chunks +19 lines, -1 line 0 comments Download
Lib/http/client.py View 1 2 3 4 5 5 chunks +20 lines, -7 lines 0 comments Download
Lib/test/test_httplib.py View 1 2 3 4 5 4 chunks +91 lines, -1 line 0 comments Download
Lib/xmlrpc/client.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
demian
http://bugs.python.org/review/3566/diff/13714/Lib/http/client.py File Lib/http/client.py (right): http://bugs.python.org/review/3566/diff/13714/Lib/http/client.py#newcode243 Lib/http/client.py:243: if self._connection_reused: I don't think that this sits quite ...
4 years ago #1
r.david.murray
This is an API review based on the docs, I haven't looked at the code ...
4 years ago #2
Martin Panter
http://bugs.python.org/review/3566/diff/13714/Lib/test/test_httplib.py File Lib/test/test_httplib.py (right): http://bugs.python.org/review/3566/diff/13714/Lib/test/test_httplib.py#newcode1021 Lib/test/test_httplib.py:1021: ('1.0', 'keep-ALIVE', True), On 2015/01/25 07:55:27, demian wrote: > ...
4 years ago #3
demian
http://bugs.python.org/review/3566/diff/13714/Lib/test/test_httplib.py File Lib/test/test_httplib.py (right): http://bugs.python.org/review/3566/diff/13714/Lib/test/test_httplib.py#newcode1021 Lib/test/test_httplib.py:1021: ('1.0', 'keep-ALIVE', True), On 2015/01/26 02:11:37, vadmium wrote: > ...
4 years ago #4
Martin Panter
https://bugs.python.org/review/3566/diff/13719/Lib/http/client.py File Lib/http/client.py (right): https://bugs.python.org/review/3566/diff/13719/Lib/http/client.py#newcode243 Lib/http/client.py:243: if self._connection_reused: On 2015/01/26 16:52:32, demian wrote: > I'm ...
4 years ago #5
demian
http://bugs.python.org/review/3566/diff/13795/Doc/library/http.client.rst File Doc/library/http.client.rst (right): http://bugs.python.org/review/3566/diff/13795/Doc/library/http.client.rst#newcode174 Doc/library/http.client.rst:174: A subclass of :exc:`ConnectionError`. Raised by Maybe move the ...
4 years ago #6
Martin Panter
https://bugs.python.org/review/3566/diff/13719/Doc/library/http.client.rst File Doc/library/http.client.rst (right): https://bugs.python.org/review/3566/diff/13719/Doc/library/http.client.rst#newcode258 Doc/library/http.client.rst:258: after a persistent connection is dropped. On 2015/01/25 22:21:24, ...
4 years ago #7
demian
http://bugs.python.org/review/3566/diff/13970/Doc/library/http.client.rst File Doc/library/http.client.rst (right): http://bugs.python.org/review/3566/diff/13970/Doc/library/http.client.rst#newcode288 Doc/library/http.client.rst:288: called automatically when making a request if the client ...
3 years, 12 months ago #8
Martin Panter
3 years, 12 months ago #9
https://bugs.python.org/review/3566/diff/13970/Doc/library/http.client.rst
File Doc/library/http.client.rst (right):

https://bugs.python.org/review/3566/diff/13970/Doc/library/http.client.rst#ne...
Doc/library/http.client.rst:288: called automatically when making a request if
the client does not already
On 2015/02/20 02:26:00, demian wrote:
> This is only true when auto_open == True.

But auto_open is undocumented, and only set to 1 (a.k.a. True) internally, so it
does not seem appropriate to mention this. Maybe I will say “By default, this is
called automatically . . .”

https://bugs.python.org/review/3566/diff/13970/Lib/test/test_httplib.py
File Lib/test/test_httplib.py (right):

https://bugs.python.org/review/3566/diff/13970/Lib/test/test_httplib.py#newco...
Lib/test/test_httplib.py:1074: # HTTPConnection.connect() should be
automatically invoked
On 2015/02/20 02:26:00, demian wrote:
> It might be worthwhile testing NotConnected is raised if conn.auto_connect is
> set to False. I don't think it's being tested anywhere else at the moment.

Since this feature is undocumented, rarely used, and I don’t know the details, I
would prefer to leave that for a separate patch.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+