Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(161260)

#29463: Change docstring to attribute from first statement.

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by songofacandy
Modified:
2 years, 10 months ago
Reviewers:
victor.stinner, storchaka+cpython, berker.peksag
CC:
Georg, haypo, Benjamin Peterson, inada.naoki, storchaka, jeff.allen, mbussonn
Visibility:
Public.

Patch Set 1 #

Total comments: 11

Patch Set 2 #

Total comments: 8

Patch Set 3 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/ast.rst View 1 2 1 chunk +11 lines, -3 lines 0 comments Download
Doc/whatsnew/3.7.rst View 1 2 1 chunk +4 lines, -0 lines 3 comments Download
Include/Python-ast.h View 1 2 3 chunks +15 lines, -10 lines 0 comments Download
Lib/ast.py View 1 2 1 chunk +1 line, -9 lines 0 comments Download
Lib/test/test_ast.py View 1 2 12 chunks +87 lines, -73 lines 0 comments Download
Lib/test/test_opcodes.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
Misc/NEWS View 1 2 1 chunk +3 lines, -0 lines 1 comment Download
Parser/Python.asdl View 1 2 1 chunk +7 lines, -4 lines 0 comments Download
Python/ast.c View 1 2 11 chunks +63 lines, -26 lines 0 comments Download
Python/compile.c View 1 2 6 chunks +17 lines, -49 lines 0 comments Download
Python/future.c View 1 2 2 chunks +1 line, -11 lines 0 comments Download
Python/importlib_external.h View 1 2 2 chunks +1245 lines, -1246 lines 0 comments Download
Python/importlib.h View 1 2 1 chunk +1598 lines, -1598 lines 0 comments Download
Python/Python-ast.c View 1 2 20 chunks +90 lines, -17 lines 0 comments Download
Tools/parser/unparse.py View 1 2 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8
victor.stinner_gmail.com
http://bugs.python.org/review/29463/diff/19931/Lib/ast.py File Lib/ast.py (right): http://bugs.python.org/review/29463/diff/19931/Lib/ast.py#newcode200 Lib/ast.py:200: text = node.docstring I like this change :-) http://bugs.python.org/review/29463/diff/19931/Lib/test/test_ast.py ...
2 years, 10 months ago #1
storchaka
http://bugs.python.org/review/29463/diff/19931/Python/ast.c File Python/ast.c (right): http://bugs.python.org/review/29463/diff/19931/Python/ast.c#newcode3535 Python/ast.c:3535: s->v.Expr.value->kind == Str_kind && Check also Constant_kind. No need ...
2 years, 10 months ago #2
berkerpeksag
I just left some suggestions about the documentation changes. Side-note: This looks like a pretty ...
2 years, 10 months ago #3
inada.naoki
http://bugs.python.org/review/29463/diff/19931/Lib/test/test_ast.py File Lib/test/test_ast.py (right): http://bugs.python.org/review/29463/diff/19931/Lib/test/test_ast.py#newcode1072 Lib/test/test_ast.py:1072: unittest.main() On 2017/02/07 09:26:50, haypo wrote: > Would it ...
2 years, 10 months ago #4
inada.naoki
http://bugs.python.org/review/29463/diff/19947/Doc/library/ast.rst File Doc/library/ast.rst (left): http://bugs.python.org/review/29463/diff/19947/Doc/library/ast.rst#oldcode139 Doc/library/ast.rst:139: On 2017/02/08 04:59:23, berkerpeksag wrote: > One more thing: ...
2 years, 10 months ago #5
victor.stinner_gmail.com
http://bugs.python.org/review/29463/diff/19949/Doc/whatsnew/3.7.rst File Doc/whatsnew/3.7.rst (right): http://bugs.python.org/review/29463/diff/19949/Doc/whatsnew/3.7.rst#newcode188 Doc/whatsnew/3.7.rst:188: anymore. (Contributed by INADA Naoki in :issue:`29463`.) Please document ...
2 years, 10 months ago #6
inada.naoki
http://bugs.python.org/review/29463/diff/19949/Doc/whatsnew/3.7.rst File Doc/whatsnew/3.7.rst (right): http://bugs.python.org/review/29463/diff/19949/Doc/whatsnew/3.7.rst#newcode188 Doc/whatsnew/3.7.rst:188: anymore. (Contributed by INADA Naoki in :issue:`29463`.) On 2017/02/08 ...
2 years, 10 months ago #7
victor.stinner_gmail.com
2 years, 10 months ago #8
http://bugs.python.org/review/29463/diff/19949/Doc/whatsnew/3.7.rst
File Doc/whatsnew/3.7.rst (right):

http://bugs.python.org/review/29463/diff/19949/Doc/whatsnew/3.7.rst#newcode188
Doc/whatsnew/3.7.rst:188: anymore.  (Contributed by INADA Naoki in
:issue:`29463`.)
>   ``co_firstlineno`` attribute of code object is also changed to
>   line number of first statement except docstring.

LGTM.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+