Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(41)

#29400: Instruction level tracing via sys.settrace

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 3 weeks ago by george.w.king
Modified:
7 months, 2 weeks ago
Reviewers:
xdegaye
CC:
haypo, xdegaye, gwk, ammar2
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Include/ceval.h View 1 1 chunk +2 lines, -1 line 0 comments Download
Include/pystate.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
Lib/test/test_sys_settrace.py View 1 1 chunk +8 lines, -0 lines 0 comments Download
Python/ceval.c View 1 5 chunks +14 lines, -1 line 0 comments Download
Python/pystate.c View 1 1 chunk +1 line, -0 lines 0 comments Download
Python/sysmodule.c View 1 5 chunks +54 lines, -6 lines 0 comments Download

Messages

Total messages: 1
xdegaye
7 months, 3 weeks ago #1
http://bugs.python.org/review/29400/diff/19891/Python/ceval.c
File Python/ceval.c (right):

http://bugs.python.org/review/29400/diff/19891/Python/ceval.c#newcode4622
Python/ceval.c:4622: /* instruction tracing must be explicitly enabled after
this call. */
This comment is a left over from the previous patch. It is confusing here.

http://bugs.python.org/review/29400/diff/19891/Python/sysmodule.c
File Python/sysmodule.c (right):

http://bugs.python.org/review/29400/diff/19891/Python/sysmodule.c#newcode476
Python/sysmodule.c:476: return Py_None;
Why not keep the original statement:
    Py_RETURN_NONE;
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7