Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4297)

#2927: expose html.parser.unescape

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by thomaspinckney3
Modified:
5 years, 4 months ago
Reviewers:
storchaka, ezio.melotti
CC:
brett.cannon, haypo, ezio.melotti, thomaspinckney3, rnk_mit.edu, BreamoreBoy, devnull_psf.upfronthosting.co.za, Martin Panter, storchaka
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 18

Patch Set 4 #

Total comments: 7

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/html.rst View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
Lib/html/__init__.py View 1 2 3 4 2 chunks +113 lines, -1 line 0 comments Download
Lib/html/parser.py View 1 2 3 4 3 chunks +5 lines, -33 lines 0 comments Download
Lib/test/test_htmlparser.py View 1 2 3 4 1 chunk +0 lines, -12 lines 0 comments Download
Lib/test/test_html.py View 1 2 3 4 1 chunk +83 lines, -3 lines 0 comments Download

Messages

Total messages: 6
storchaka_gmail.com
http://bugs.python.org/review/2927/diff/9964/Lib/html/__init__.py File Lib/html/__init__.py (right): http://bugs.python.org/review/2927/diff/9964/Lib/html/__init__.py#newcode6 Lib/html/__init__.py:6: from html.entities import html5 ... as _re ... as ...
5 years, 4 months ago #1
ezio.melotti
Thanks for the review, I'll update an updated patch shortly. http://bugs.python.org/review/2927/diff/9964/Lib/html/__init__.py File Lib/html/__init__.py (right): http://bugs.python.org/review/2927/diff/9964/Lib/html/__init__.py#newcode6 ...
5 years, 4 months ago #2
ezio.melotti
http://bugs.python.org/review/2927/diff/9977/Lib/test/test_html.py File Lib/test/test_html.py (right): http://bugs.python.org/review/2927/diff/9977/Lib/test/test_html.py#newcode21 Lib/test/test_html.py:21: def check(text, expected, check_formats=False): The third arg shouldn't be ...
5 years, 4 months ago #3
storchaka_gmail.com
http://bugs.python.org/review/2927/diff/9964/Lib/html/__init__.py File Lib/html/__init__.py (right): http://bugs.python.org/review/2927/diff/9964/Lib/html/__init__.py#newcode66 Lib/html/__init__.py:66: # 0x0001 to 0x0008 On 2013/11/19 11:41:16, ezio.melotti wrote: ...
5 years, 4 months ago #4
ezio.melotti
I also checked the results of these tests on Firefox with a jquery snippet, but ...
5 years, 4 months ago #5
storchaka_gmail.com
5 years, 4 months ago #6
LGTM.

http://bugs.python.org/review/2927/diff/9977/Lib/test/test_html.py
File Lib/test/test_html.py (right):

http://bugs.python.org/review/2927/diff/9977/Lib/test/test_html.py#newcode95
Lib/test/test_html.py:95: 
On 2013/11/19 17:47:45, ezio.melotti wrote:
> On 2013/11/19 17:36:23, storchaka wrote:
> > I don't see tests like: '&#33a' -> '!a', '&#x21g' -> '!g'.
> 
> They are at line 46/47.

Ah, well.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+