Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(75262)

#29259: Add tp_fastcall to PyTypeObject: support FASTCALL calling convention for all callable objects

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by vstinner
Modified:
2 years, 6 months ago
Reviewers:
songofacandy
CC:
haypo, inada.naoki, devnull_psf.upfronthosting.co.za, storchaka, jdemeyer
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Total comments: 2

Patch Set 5 #

Patch Set 6 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Include/abstract.h View 1 2 3 4 5 2 chunks +31 lines, -14 lines 0 comments Download
Include/descrobject.h View 1 2 3 4 5 3 chunks +11 lines, -0 lines 0 comments Download
Include/methodobject.h View 1 2 3 4 5 2 chunks +2 lines, -4 lines 0 comments Download
Include/object.h View 1 2 3 4 5 4 chunks +18 lines, -10 lines 0 comments Download
Lib/test/test_gdb.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_sys.py View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
Modules/_operator.c View 1 2 3 4 5 10 chunks +35 lines, -19 lines 0 comments Download
Objects/abstract.c View 1 2 3 4 5 11 chunks +140 lines, -12 lines 2 comments Download
Objects/classobject.c View 1 2 3 4 5 4 chunks +6 lines, -4 lines 0 comments Download
Objects/descrobject.c View 1 2 3 4 5 20 chunks +90 lines, -84 lines 1 comment Download
Objects/funcobject.c View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
Objects/methodobject.c View 1 2 3 4 5 11 chunks +47 lines, -58 lines 2 comments Download
Objects/typeobject.c View 1 2 3 4 5 14 chunks +145 lines, -11 lines 2 comments Download
Objects/weakrefobject.c View 1 2 3 4 5 3 chunks +12 lines, -2 lines 0 comments Download
Tools/gdb/libpython.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
inada.naoki
LGTM http://bugs.python.org/review/29259/diff/19782/Objects/descrobject.c File Objects/descrobject.c (right): http://bugs.python.org/review/29259/diff/19782/Objects/descrobject.c#newcode528 Objects/descrobject.c:528: | Py_TPFLAGS_HAVE_FASTCALL, /* tp_flags */ PyMethodDescr_Type didn't change ...
2 years, 7 months ago #1
victor.stinner_gmail.com
http://bugs.python.org/review/29259/diff/19782/Objects/descrobject.c File Objects/descrobject.c (right): http://bugs.python.org/review/29259/diff/19782/Objects/descrobject.c#newcode528 Objects/descrobject.c:528: | Py_TPFLAGS_HAVE_FASTCALL, /* tp_flags */ On 2017/01/20 05:23:39, inada.naoki ...
2 years, 7 months ago #2
victor.stinner_gmail.com
http://bugs.python.org/review/29259/diff/19837/Objects/abstract.c File Objects/abstract.c (right): http://bugs.python.org/review/29259/diff/19837/Objects/abstract.c#newcode2290 Objects/abstract.c:2290: int _Py_NO_INLINE Not sure if _Py_NO_INLINE is needed here. ...
2 years, 6 months ago #3
inada.naoki
2 years, 6 months ago #4
I don't understand update_one_slot() for now.
Other part looks good.

http://bugs.python.org/review/29259/diff/19837/Objects/typeobject.c
File Objects/typeobject.c (right):

http://bugs.python.org/review/29259/diff/19837/Objects/typeobject.c#newcode6226
Objects/typeobject.c:6226: PyObject *meth = lookup_method(self, &PyId___call__);
slot_tp_call has _Py_IDENTIFIER(__call__) too.
Let's move them at top of this file.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+