Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

#29204: Add code deprecations in ElementTree

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years ago by storchaka+cpython
Modified:
3 years ago
Reviewers:
vadmium+py
CC:
scoder, ned.deily, eli.bendersky, Martin Panter, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_xml_etree_c.py View 1 chunk +5 lines, -3 lines 2 comments Download
Lib/test/test_xml_etree.py View 9 chunks +41 lines, -48 lines 0 comments Download
Lib/xml/etree/cElementTree.py View 1 chunk +4 lines, -0 lines 0 comments Download
Lib/xml/etree/ElementTree.py View 2 chunks +6 lines, -1 line 0 comments Download
Modules/clinic/_elementtree.c.h View 2 chunks +30 lines, -1 line 0 comments Download
Modules/_elementtree.c View 4 chunks +37 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Martin Panter
http://bugs.python.org/review/29204/diff/19687/Lib/test/test_xml_etree_c.py File Lib/test/test_xml_etree_c.py (right): http://bugs.python.org/review/29204/diff/19687/Lib/test/test_xml_etree_c.py#newcode12 Lib/test/test_xml_etree_c.py:12: cET_alias = import_fresh_module('xml.etree.cElementTree', Can’t you just pass import_fresh_module(deprecated=True)?
3 years ago #1
storchaka
3 years ago #2
http://bugs.python.org/review/29204/diff/19687/Lib/test/test_xml_etree_c.py
File Lib/test/test_xml_etree_c.py (right):

http://bugs.python.org/review/29204/diff/19687/Lib/test/test_xml_etree_c.py#n...
Lib/test/test_xml_etree_c.py:12: cET_alias =
import_fresh_module('xml.etree.cElementTree',
On 2017/01/08 12:29:09, vadmium wrote:
> Can’t you just pass import_fresh_module(deprecated=True)?

Thanks, I have missed this.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+