Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(91563)

#29102: Add an id field to PyInterpreterState.

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 3 months ago by ericsnowcurrently
Modified:
2 years, 3 months ago
Reviewers:
ncoghlan
CC:
brett.cannon, Nick Coghlan, haypo, Graham.Dumpleton_gmail.com, eric.snow, storchaka, steve.dower
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 7

Patch Set 3 #

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/c-api/init.rst View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
Include/pystate.h View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
Lib/test/test_capi.py View 1 2 3 2 chunks +79 lines, -5 lines 0 comments Download
Programs/_testembed.c View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
Python/pylifecycle.c View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
Python/pystate.c View 1 2 3 3 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Nick Coghlan
In addition to the major question around the type used for interpreter IDs, a couple ...
2 years, 3 months ago #1
eric.snow
http://bugs.python.org/review/29102/diff/19610/Python/pylifecycle.c File Python/pylifecycle.c (right): http://bugs.python.org/review/29102/diff/19610/Python/pylifecycle.c#newcode347 Python/pylifecycle.c:347: _PyInterpreterState_next_id = 1; On 2016/12/31 05:31:37, Nick Coghlan wrote: ...
2 years, 3 months ago #2
eric.snow
2 years, 3 months ago #3
I've addressed all review comments and will have a new patch up momentarily.

http://bugs.python.org/review/29102/diff/19610/Programs/_testembed.c
File Programs/_testembed.c (right):

http://bugs.python.org/review/29102/diff/19610/Programs/_testembed.c#newcode25
Programs/_testembed.c:25: /* Just output some debug stuff */
On 2016/12/31 05:31:37, Nick Coghlan wrote:
> This comment is out of date now, as the test case actually reads this and
hence
> the two need to be kept in sync.

Good point.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+