Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

#28961: unittest.mock._Call ignores `name` parameter

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by gansteed
Modified:
3 years, 5 months ago
Reviewers:
barry
CC:
haypo, Michael Foord, devnull_psf.upfronthosting.co.za, berkerpeksag, ebarry, jiajun.huang
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 2

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/unittest/mock.py View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
Lib/unittest/test/testmock/testhelpers.py View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2
ebarry
http://bugs.python.org/review/28961/diff/19454/Lib/unittest/mock.py File Lib/unittest/mock.py (right): http://bugs.python.org/review/28961/diff/19454/Lib/unittest/mock.py#newcode1966 Lib/unittest/mock.py:1966: name = '' if name is None else name ...
3 years, 5 months ago #1
jiajun.huang
3 years, 5 months ago #2
`Add Another Patch Set` button shoot me a 500 internal server
error(http://bugs.python.org/review/28961/#ps19454). so I've uploaded another
patch in http://bugs.python.org/issue28961.

http://bugs.python.org/review/28961/diff/19454/Lib/unittest/mock.py
File Lib/unittest/mock.py (right):

http://bugs.python.org/review/28961/diff/19454/Lib/unittest/mock.py#newcode1966
Lib/unittest/mock.py:1966: name = '' if name is None else name
On 2016/12/14 04:06:39, ebarry wrote:
> I would rather do it on two lines (i.e. `if name is None: name = ''`); it's
> easier to read, and the additional indentation makes it clearer that there's a
> branch there.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+