Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(72783)

#28927: bytes.fromhex should ignore all whitespace

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by nneonneo
Modified:
2 years, 10 months ago
Reviewers:
storchaka+cpython
CC:
terry.reedy, Nick Coghlan, nneonneo, devnull_psf.upfronthosting.co.za, Martin Panter, storchaka
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 1

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/stdtypes.rst View 1 2 2 chunks +10 lines, -2 lines 0 comments Download
Doc/whatsnew/3.7.rst View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
Lib/test/test_bytes.py View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
Objects/bytesobject.c View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1
storchaka
2 years, 10 months ago #1
http://bugs.python.org/review/28927/diff/19520/Doc/library/stdtypes.rst
File Doc/library/stdtypes.rst (right):

http://bugs.python.org/review/28927/diff/19520/Doc/library/stdtypes.rst#newco...
Doc/library/stdtypes.rst:2323: :meth:`bytes.fromhex` now skips all ASCII
whitespace in the string, not just spaces.
The line is too long.

PEP 12: You should fill your paragraphs to column 70, but under no circumstances
should your lines extend past column 79.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+