Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(168209)

#28860: Fixed all the doctest failures in Doc/library/configparser.rst

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years ago by marco.buttu
Modified:
3 years ago
Reviewers:
berker.peksag
CC:
brett.cannon, terry.reedy, docs_python.org, Zach Ware, marco.buttu
Visibility:
Public.

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/configparser.rst View 8 chunks +22 lines, -17 lines 7 comments Download

Messages

Total messages: 4
berkerpeksag
http://bugs.python.org/review/28860/diff/19350/Doc/library/configparser.rst File Doc/library/configparser.rst (left): http://bugs.python.org/review/28860/diff/19350/Doc/library/configparser.rst#oldcode73 Doc/library/configparser.rst:73: >>> import configparser Can this be removed now? (since ...
3 years ago #1
marco.buttu
http://bugs.python.org/review/28860/diff/19350/Doc/library/configparser.rst File Doc/library/configparser.rst (left): http://bugs.python.org/review/28860/diff/19350/Doc/library/configparser.rst#oldcode73 Doc/library/configparser.rst:73: >>> import configparser On 2016/12/05 12:27:28, berkerpeksag wrote: > ...
3 years ago #2
berkerpeksag
http://bugs.python.org/review/28860/diff/19350/Doc/library/configparser.rst File Doc/library/configparser.rst (left): http://bugs.python.org/review/28860/diff/19350/Doc/library/configparser.rst#oldcode73 Doc/library/configparser.rst:73: >>> import configparser On 2016/12/05 13:20:11, marco.buttu wrote: > ...
3 years ago #3
marco.buttu
3 years ago #4
http://bugs.python.org/review/28860/diff/19350/Doc/library/configparser.rst
File Doc/library/configparser.rst (left):

http://bugs.python.org/review/28860/diff/19350/Doc/library/configparser.rst#o...
Doc/library/configparser.rst:73: >>> import configparser
On 2016/12/05 13:29:56, berkerpeksag wrote:
> On 2016/12/05 13:20:11, marco.buttu wrote:
> > On 2016/12/05 12:27:28, berkerpeksag wrote:
> > > Can this be removed now? (since we've already import it in testsetup?)
> > 
> > I think it is really important to keep it at the beginning, because the code
> we
> > show to the reader has to be working code. The user has to import
configparser
> > in the shell before executing manually the example. The import in the
> testsetup
> > has just the purpose to avoid the same import in all the examples, when they
> > belong to the same session.
> 
> Yes, that's a good point. I didn't notice it was the first example of the
> documentation.

In any case, the testsetup is not required (we can remove it), because all the
doctests are executed in the same session, and configparser is imported from the
beginning. So, in a final patch, I will remove it
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+