Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1233)

#28822: Fix indices handling in PyUnicode_FindChar

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by angwerzx
Modified:
2 years, 5 months ago
Reviewers:
victor.stinner, storchaka+cpython
CC:
haypo, devnull_psf.upfronthosting.co.za, storchaka, xiang.zhang
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_unicode.py View 1 1 chunk +23 lines, -0 lines 4 comments Download
Modules/_testcapimodule.c View 1 2 chunks +22 lines, -0 lines 0 comments Download
Objects/unicodeobject.c View 1 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 5
victor.stinner_gmail.com
http://bugs.python.org/review/28822/diff/19307/Lib/test/test_unicode.py File Lib/test/test_unicode.py (right): http://bugs.python.org/review/28822/diff/19307/Lib/test/test_unicode.py#newcode2736 Lib/test/test_unicode.py:2736: str = "bye;\xe0 bient\xf4t;\u518d\u89c1;\U0001F44B" * 2 I dislike the ...
2 years, 5 months ago #1
storchaka
http://bugs.python.org/review/28822/diff/19307/Lib/test/test_unicode.py File Lib/test/test_unicode.py (right): http://bugs.python.org/review/28822/diff/19307/Lib/test/test_unicode.py#newcode2736 Lib/test/test_unicode.py:2736: str = "bye;\xe0 bient\xf4t;\u518d\u89c1;\U0001F44B" * 2 I think there ...
2 years, 5 months ago #2
victor.stinner_gmail.com
http://bugs.python.org/review/28822/diff/19316/Lib/test/test_unicode.py File Lib/test/test_unicode.py (right): http://bugs.python.org/review/28822/diff/19316/Lib/test/test_unicode.py#newcode2731 Lib/test/test_unicode.py:2731: # Test PyUnicode_FindChar() Put the comment in the function ...
2 years, 5 months ago #3
xiang.zhang
http://bugs.python.org/review/28822/diff/19316/Lib/test/test_unicode.py File Lib/test/test_unicode.py (right): http://bugs.python.org/review/28822/diff/19316/Lib/test/test_unicode.py#newcode2731 Lib/test/test_unicode.py:2731: # Test PyUnicode_FindChar() On 2016/11/29 18:13:50, haypo wrote: > ...
2 years, 5 months ago #4
victor.stinner_gmail.com
2 years, 5 months ago #5
http://bugs.python.org/review/28822/diff/19316/Lib/test/test_unicode.py
File Lib/test/test_unicode.py (right):

http://bugs.python.org/review/28822/diff/19316/Lib/test/test_unicode.py#newco...
Lib/test/test_unicode.py:2731: # Test PyUnicode_FindChar()
Oh, you're right. This file is not consistent :-) At least, try to keep this
test case class consistent, so yeah, ignore my comment.

(Moreover, I wrote this class, so I'm also inconsistent with myself...)
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+