Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(41030)

#28762: configure links with lockf and F_LOCK is not declared in Android API 24

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by xdegaye
Modified:
2 years, 9 months ago
Reviewers:
victor.stinner
CC:
haypo, xdegaye, devnull_psf.upfronthosting.co.za, Chi Hsuan Yen
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
configure.ac View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 2
victor.stinner_gmail.com
http://bugs.python.org/review/28762/diff/19239/configure.ac File configure.ac (right): http://bugs.python.org/review/28762/diff/19239/configure.ac#newcode3764 configure.ac:3764: # On Android API level 24, F_LOCK is not ...
2 years, 9 months ago #1
xdegaye
2 years, 9 months ago #2
http://bugs.python.org/review/28762/diff/19239/configure.ac
File configure.ac (right):

http://bugs.python.org/review/28762/diff/19239/configure.ac#newcode3764
configure.ac:3764: # On Android API level 24, F_LOCK is not defined even though
lockf is
On 2016/12/21 17:27:37, haypo wrote:
> Please add the issue number:
> 
> # Issue #28762: On Android ...
> 
> About the API version, it seems like there is also the "NDK" API version which
> matters, since android-ndk-r13 doesn't have it but "Android NDK r14 beta1" has
> it. Maybe mention also the NDK version?

Ok, I will mention the issue number and NDK version.

http://bugs.python.org/review/28762/diff/19239/configure.ac#newcode3768
configure.ac:3768: [AC_DEFINE(HAVE_LOCKF, 1, Define to 1 if you have the 'lockf'
function.)
On 2016/12/21 17:27:37, haypo wrote:
> The define now indirectly announces that F_LOCK constant is also defined, no?
I
> suggest to update the comment:
> 
> Define to 1 if you have the 'lockf' function and the 'F_LOCK' constant.

Ok.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+