Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33154)

#28739: PEP 498: docstrings as f-strings

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by yselivanov
Modified:
2 years, 6 months ago
Reviewers:
eric, storchaka+cpython
CC:
gvanrossum, rhettinger, terry.reedy, eric.smith, ned.deily, docs_python.org, devnull_psf.upfronthosting.co.za, Martin Panter, storchaka, Yury Selivanov, Mariatta, joakim.soderlund_gmail.com
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_fstring.py View 1 chunk +14 lines, -10 lines 0 comments Download
Python/ast.c View 5 chunks +4 lines, -6 lines 2 comments Download
Python/compile.c View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2
eric.smith
One small nit, otherwise looks good. http://bugs.python.org/review/28739/diff/19295/Python/ast.c File Python/ast.c (right): http://bugs.python.org/review/28739/diff/19295/Python/ast.c#newcode4966 Python/ast.c:4966: if (!state->fmode && ...
2 years, 6 months ago #1
storchaka
2 years, 6 months ago #2
http://bugs.python.org/review/28739/diff/19295/Python/ast.c
File Python/ast.c (right):

http://bugs.python.org/review/28739/diff/19295/Python/ast.c#newcode4966
Python/ast.c:4966: if (!state->fmode && state->expr_list.size == 0) {
On 2016/12/11 16:19:20, eric.smith wrote:
> I would make both of these tests "== 0", or use "!" on both.

Maybe testing state->expr_list.size is not needed at all. It always is 0 when
fmode is not set.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+