Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Delta Between Two Patch Sets: Lib/test/test_range.py

Issue 28376: assertion failure in rangeobject.c
Left Patch Set: Created 3 years, 4 months ago
Right Patch Set: Created 3 years, 4 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | Objects/rangeobject.c » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 # Python test set -- built-in functions 1 # Python test set -- built-in functions
2 2
3 import unittest 3 import unittest
4 import sys 4 import sys
5 import pickle 5 import pickle
6 import itertools 6 import itertools
7 import test.support 7 import test.support
8 import re
9 8
10 # pure Python implementations (3 args only), for comparison 9 # pure Python implementations (3 args only), for comparison
11 def pyrange(start, stop, step): 10 def pyrange(start, stop, step):
12 if (start - stop) // step < 0: 11 if (start - stop) // step < 0:
13 # replace stop with next element in the sequence of integers 12 # replace stop with next element in the sequence of integers
14 # that are congruent to start modulo step. 13 # that are congruent to start modulo step.
15 stop += (start - stop) % step 14 stop += (start - stop) % step
16 while start != stop: 15 while start != stop:
17 yield start 16 yield start
18 start += step 17 start += step
(...skipping 469 matching lines...) Expand 10 before | Expand all | Expand 10 after
488 iter2 = pyrange(start, end, step) 487 iter2 = pyrange(start, end, step)
489 test_id = "range({}, {}, {})".format(start, end, step) 488 test_id = "range({}, {}, {})".format(start, end, step)
490 # check first 100 entries 489 # check first 100 entries
491 self.assert_iterators_equal(iter1, iter2, test_id, limit=100) 490 self.assert_iterators_equal(iter1, iter2, test_id, limit=100)
492 491
493 iter1 = reversed(range(start, end, step)) 492 iter1 = reversed(range(start, end, step))
494 iter2 = pyrange_reversed(start, end, step) 493 iter2 = pyrange_reversed(start, end, step)
495 test_id = "reversed(range({}, {}, {}))".format(start, end, step) 494 test_id = "reversed(range({}, {}, {}))".format(start, end, step)
496 self.assert_iterators_equal(iter1, iter2, test_id, limit=100) 495 self.assert_iterators_equal(iter1, iter2, test_id, limit=100)
497 496
498 @test.support.cpython_only 497 @test.support.cpython_only
storchaka 2016/10/07 14:32:00 I think this decorator is not needed. Other implem
Oren Milman 2016/10/07 16:10:00 But the test checks the exact wording of the error
storchaka 2016/10/07 16:44:09 Good point. I think we should not test exact error
499 def test_range_iterators_invocation(self): 498 def test_range_iterator_invocation(self):
499 import _testcapi
500 rangeiter_type = type(iter(range(0))) 500 rangeiter_type = type(iter(range(0)))
501 long_rangeiter_type = type(iter(range(1 << 1000))) 501
502 for iter_type in [rangeiter_type, long_rangeiter_type]: 502 self.assertWarns(DeprecationWarning, rangeiter_type, 1, 3, 1)
503 self.assertRaisesRegex(TypeError, 503
504 re.escape("cannot create '{}' instances" 504 with test.support.check_warnings(('', DeprecationWarning)):
505 "".format(iter_type.__name__)), 505 # rangeiter_new doesn't take keyword arguments
506 iter_type) 506 with self.assertRaises(TypeError):
507 rangeiter_type(a=1)
508
509 # rangeiter_new takes exactly 3 arguments
510 self.assertRaises(TypeError, rangeiter_type)
511 self.assertRaises(TypeError, rangeiter_type, 1)
512 self.assertRaises(TypeError, rangeiter_type, 1, 1)
513 self.assertRaises(TypeError, rangeiter_type, 1, 1, 1, 1)
514
515 # start, stop and stop must fit in C long
516 for good_val in [_testcapi.LONG_MAX, _testcapi.LONG_MIN]:
517 rangeiter_type(good_val, good_val, good_val)
518 for bad_val in [_testcapi.LONG_MAX + 1, _testcapi.LONG_MIN - 1]:
519 self.assertRaises(OverflowError,
520 rangeiter_type, bad_val, 1, 1)
521 self.assertRaises(OverflowError,
522 rangeiter_type, 1, bad_val, 1)
523 self.assertRaises(OverflowError,
524 rangeiter_type, 1, 1, bad_val)
525
526 # step mustn't be zero
527 self.assertRaises(ValueError, rangeiter_type, 1, 1, 0)
507 528
508 def test_slice(self): 529 def test_slice(self):
509 def check(start, stop, step=None): 530 def check(start, stop, step=None):
510 i = slice(start, stop, step) 531 i = slice(start, stop, step)
511 self.assertEqual(list(r[i]), list(r)[i]) 532 self.assertEqual(list(r[i]), list(r)[i])
512 self.assertEqual(len(r[i]), len(list(r)[i])) 533 self.assertEqual(len(r[i]), len(list(r)[i]))
513 for r in [range(10), 534 for r in [range(10),
514 range(0), 535 range(0),
515 range(1, 9, 3), 536 range(1, 9, 3),
516 range(8, 0, -3), 537 range(8, 0, -3),
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
654 675
655 with self.assertRaises(AttributeError): 676 with self.assertRaises(AttributeError):
656 del rangeobj.start 677 del rangeobj.start
657 with self.assertRaises(AttributeError): 678 with self.assertRaises(AttributeError):
658 del rangeobj.stop 679 del rangeobj.stop
659 with self.assertRaises(AttributeError): 680 with self.assertRaises(AttributeError):
660 del rangeobj.step 681 del rangeobj.step
661 682
662 if __name__ == "__main__": 683 if __name__ == "__main__":
663 unittest.main() 684 unittest.main()
LEFTRIGHT

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+