Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

#28376: assertion failure in rangeobject.c

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 3 months ago by orenmn
Modified:
3 years, 3 months ago
Reviewers:
storchaka+cpython
CC:
inada.naoki, devnull_psf.upfronthosting.co.za, storchaka, ebarry, Oren Milman
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Total comments: 9

Patch Set 5 #

Total comments: 1

Patch Set 6 #

Total comments: 1

Patch Set 7 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_range.py View 1 2 3 4 5 6 2 chunks +33 lines, -0 lines 0 comments Download
Objects/rangeobject.c View 1 2 3 4 5 6 1 chunk +18 lines, -3 lines 0 comments Download

Messages

Total messages: 8
storchaka
http://bugs.python.org/review/28376/diff/18787/Lib/test/test_range.py File Lib/test/test_range.py (right): http://bugs.python.org/review/28376/diff/18787/Lib/test/test_range.py#newcode496 Lib/test/test_range.py:496: def test_range_iterator_invocation(self): Seems the ability to call range iterator ...
3 years, 3 months ago #1
storchaka
http://bugs.python.org/review/28376/diff/18796/Lib/_collections_abc.py File Lib/_collections_abc.py (right): http://bugs.python.org/review/28376/diff/18796/Lib/_collections_abc.py#newcode32 Lib/_collections_abc.py:32: # Note: in other implementations, these types might not ...
3 years, 3 months ago #2
Oren Milman
http://bugs.python.org/review/28376/diff/18796/Lib/_collections_abc.py File Lib/_collections_abc.py (right): http://bugs.python.org/review/28376/diff/18796/Lib/_collections_abc.py#newcode229 Lib/_collections_abc.py:229: Iterator.register(longrange_iterator) On 2016/10/07 14:32:00, storchaka wrote: > Is this ...
3 years, 3 months ago #3
storchaka
http://bugs.python.org/review/28376/diff/18796/Lib/_collections_abc.py File Lib/_collections_abc.py (right): http://bugs.python.org/review/28376/diff/18796/Lib/_collections_abc.py#newcode229 Lib/_collections_abc.py:229: Iterator.register(longrange_iterator) On 2016/10/07 16:10:00, Oren Milman wrote: > On ...
3 years, 3 months ago #4
Oren Milman
http://bugs.python.org/review/28376/diff/18796/Lib/_collections_abc.py File Lib/_collections_abc.py (right): http://bugs.python.org/review/28376/diff/18796/Lib/_collections_abc.py#newcode229 Lib/_collections_abc.py:229: Iterator.register(longrange_iterator) On 2016/10/07 16:44:09, storchaka wrote: > On 2016/10/07 ...
3 years, 3 months ago #5
storchaka
http://bugs.python.org/review/28376/diff/18796/Lib/_collections_abc.py File Lib/_collections_abc.py (right): http://bugs.python.org/review/28376/diff/18796/Lib/_collections_abc.py#newcode229 Lib/_collections_abc.py:229: Iterator.register(longrange_iterator) On 2016/10/08 13:08:05, Oren Milman wrote: > On ...
3 years, 3 months ago #6
storchaka
http://bugs.python.org/review/28376/diff/18809/Lib/test/test_range.py File Lib/test/test_range.py (right): http://bugs.python.org/review/28376/diff/18809/Lib/test/test_range.py#newcode506 Lib/test/test_range.py:506: rangeiter_type(a=1) Aren't all invocations of rangeiter_type emit DeprecationWarning? Run ...
3 years, 3 months ago #7
storchaka
3 years, 3 months ago #8
http://bugs.python.org/review/28376/diff/18810/Objects/rangeobject.c
File Objects/rangeobject.c (right):

http://bugs.python.org/review/28376/diff/18810/Objects/rangeobject.c#newcode832
Objects/rangeobject.c:832: static PyObject *rangeiter_new(PyTypeObject *,
PyObject *args, PyObject *kw);
warning: ‘rangeiter_new’ declared ‘static’ but never defined [-Wunused-function]
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+