Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(22)

#28287: Refactor subprocess.Popen to let a subclass handle IO asynchronously

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 months ago by martius
Modified:
3 weeks, 3 days ago
Reviewers:
pitrou
CC:
gregory.p.smith, AntoinePitrou, giampaolo.rodola, Yury Selivanov, martius
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/subprocess.py View 6 chunks +79 lines, -63 lines 1 comment Download

Messages

Total messages: 1
AntoinePitrou
3 weeks, 3 days ago #1
This looks reasonable on the whole.  I would like to see docstrings for the new
private methods.

https://bugs.python.org/review/28287/diff/18677/Lib/subprocess.py
File Lib/subprocess.py (right):

https://bugs.python.org/review/28287/diff/18677/Lib/subprocess.py#newcode1500
Lib/subprocess.py:1500: if p2cread != -1 and p2cwrite != -1 and p2cread !=
devnull_fd:
If `to_close` is a set then the comparisons to `devnull_fd` are not required
anymore?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7