Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

#28228: imghdr does not support pathlib

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by ethan
Modified:
3 years, 4 months ago
Reviewers:
storchaka+cpython, berker.peksag
CC:
brett.cannon, ned.deily, stoneleaf, devnull_psf.upfronthosting.co.za, berkerpeksag, storchaka, 4simple-org
Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/imghdr.py View 1 1 chunk +3 lines, -1 line 0 comments Download
Lib/test/test_imghdr.py View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2
storchaka
http://bugs.python.org/review/28228/diff/18630/Lib/imghdr.py File Lib/imghdr.py (right): http://bugs.python.org/review/28228/diff/18630/Lib/imghdr.py#newcode15 Lib/imghdr.py:15: if isinstance(file, (str, PathLike)): Or maybe use the test ...
3 years, 5 months ago #1
berkerpeksag
3 years, 4 months ago #2
http://bugs.python.org/review/28228/diff/18630/Lib/test/test_imghdr.py
File Lib/test/test_imghdr.py (right):

http://bugs.python.org/review/28228/diff/18630/Lib/test/test_imghdr.py#newcode54
Lib/test/test_imghdr.py:54: for filename, expected in TEST_FILES:
Since this is a new test we can, it would nice to use subTest() here.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+