Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

#28199: Compact dict resizing is doing too much work

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by raymond.hettinger
Modified:
3 years, 5 months ago
Reviewers:
angwerzx, songofacandy
CC:
rhettinger, jaraco, haypo, ned.deily, inada.naoki, devnull_psf.upfronthosting.co.za, storchaka, xiang.zhang
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Objects/dictobject.c View 1 2 3 4 chunks +63 lines, -60 lines 0 comments Download

Messages

Total messages: 2
xiang.zhang
LGTM http://bugs.python.org/review/28199/diff/18704/Objects/dictobject.c File Objects/dictobject.c (right): http://bugs.python.org/review/28199/diff/18704/Objects/dictobject.c#newcode1228 Objects/dictobject.c:1228: /* NOTE: Current odict checks mp->ma_keys to detect ...
3 years, 6 months ago #1
inada.naoki
3 years, 6 months ago #2
On 2016/09/30 08:23:27, xiang.zhang wrote:
> LGTM
> 
> http://bugs.python.org/review/28199/diff/18704/Objects/dictobject.c
> File Objects/dictobject.c (right):
> 
>
http://bugs.python.org/review/28199/diff/18704/Objects/dictobject.c#newcode1228
> Objects/dictobject.c:1228: /* NOTE: Current odict checks mp->ma_keys to detect
> risize happen.
> s/risize/resize

Thanks, I'll fix it in next patch.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+