Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(181728)

Unified Diff: Objects/dictobject.c

Issue 28189: dictitems_contains swallows compare errors
Patch Set: Created 2 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Lib/test/test_dictviews.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
--- a/Objects/dictobject.c Sat Sep 17 01:30:48 2016 +0300
+++ b/Objects/dictobject.c Sat Sep 17 23:14:03 2016 +0800
@@ -4035,7 +4035,7 @@
return 0;
key = PyTuple_GET_ITEM(obj, 0);
value = PyTuple_GET_ITEM(obj, 1);
- found = PyDict_GetItem((PyObject *)dv->dv_dict, key);
+ found = PyDict_GetItemWithError((PyObject *)dv->dv_dict, key);
if (found == NULL) {
if (PyErr_Occurred())
return -1;
« no previous file with comments | « Lib/test/test_dictviews.py ('k') | no next file » | no next file with comments »

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+