Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(159654)

#28128: Improve the warning message for invalid escape sequences

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 2 months ago by yan12125
Modified:
3 years ago
Reviewers:
storchaka+cpython
CC:
rhettinger, Nick Coghlan, eric.smith, ned.deily, ezio.melotti, r.david.murray, encukou, devnull_psf.upfronthosting.co.za, Martin Panter, storchaka, Yury Selivanov, Tim.Graham, Chi Hsuan Yen, ebarry
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 2

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Include/bytesobject.h View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
Include/unicodeobject.h View 1 2 3 4 5 1 chunk +11 lines, -0 lines 0 comments Download
Lib/test/test_string_literals.py View 1 2 3 4 5 3 chunks +27 lines, -0 lines 0 comments Download
Lib/test/test_unicode.py View 1 2 3 4 5 1 chunk +0 lines, -7 lines 0 comments Download
Objects/bytesobject.c View 1 2 3 4 5 4 chunks +33 lines, -4 lines 0 comments Download
Objects/unicodeobject.c View 1 2 3 4 5 4 chunks +32 lines, -6 lines 0 comments Download
Python/ast.c View 1 2 3 4 5 4 chunks +61 lines, -5 lines 0 comments Download

Messages

Total messages: 1
storchaka
3 years ago #1
Seems bytesobject.h contains unrelated changes.

http://bugs.python.org/review/28128/diff/19014/Include/bytesobject.h
File Include/bytesobject.h (right):

http://bugs.python.org/review/28128/diff/19014/Include/bytesobject.h#newcode47
Include/bytesobject.h:47: PyType_FastSubclass(Py_TYPE(op),
Py_TPFLAGS_BYTES_SUBCLASS)
Unrelated change.

http://bugs.python.org/review/28128/diff/19014/Include/bytesobject.h#newcode80
Include/bytesobject.h:80: const char**);
If there is a space between "char" and "*" in above lines, it should be here
too.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+