Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1275)

#28025: Use IntEnum and IntFlags in ssl module

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by lists
Modified:
1 year, 1 month ago
Reviewers:
ethan
CC:
bill.janssen_gmail.com, giampaolo.rodola, christian.heimes, alex, stoneleaf, devnull_psf.upfronthosting.co.za, dstufft
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/ssl.rst View 1 6 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 1
stoneleaf
1 year, 1 month ago #1
http://bugs.python.org/review/28025/diff/18412/Lib/ssl.py
File Lib/ssl.py (right):

http://bugs.python.org/review/28025/diff/18412/Lib/ssl.py#newcode154
Lib/ssl.py:154: _SSLv2_IF_EXISTS = hasattr(_SSLMethod, 'PROTOCOL_SSLv2')
Shouldn't this be

  getattr(_SSLMethod, 'PROTOCOL_SSLv2', None)

?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7