Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

#28008: PEP 530, asynchronous comprehensions implementation

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by yselivanov
Modified:
3 years, 8 months ago
Reviewers:
victor.stinner
CC:
haypo, ned.deily, lukasz.langa, devnull_psf.upfronthosting.co.za, Yury Selivanov
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Grammar/Grammar View 1 chunk +1 line, -1 line 0 comments Download
Include/Python-ast.h View 2 chunks +3 lines, -2 lines 0 comments Download
Lib/test/test_coroutines.py View 2 chunks +263 lines, -32 lines 0 comments Download
Parser/Python.asdl View 1 chunk +1 line, -1 line 0 comments Download
Python/ast.c View 3 chunks +24 lines, -11 lines 0 comments Download
Python/compile.c View 5 chunks +189 lines, -11 lines 1 comment Download
Python/graminit.c View 2 chunks +23 lines, -18 lines 0 comments Download
Python/Python-ast.c View 7 chunks +24 lines, -3 lines 0 comments Download
Python/symtable.c View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2
victor.stinner_gmail.com
http://bugs.python.org/review/28008/diff/18442/Python/compile.c File Python/compile.c (right): http://bugs.python.org/review/28008/diff/18442/Python/compile.c#newcode3752 Python/compile.c:3752: static PyObject *stop_aiter_error = NULL; You should use: _Py_IDENTIFIEER(StopAsyncIteration); ...
3 years, 8 months ago #1
Yury Selivanov
3 years, 8 months ago #2
Thanks for the review!
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+