Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5850)

#27963: null poiter dereference in set_conversion_mode due uncheck _ctypes_conversion_errors

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by minhrau.vc.365
Modified:
2 years, 7 months ago
Reviewers:
storchaka+cpython
CC:
devnull_psf.upfronthosting.co.za, storchaka, xiang.zhang, minhrau.vc.365_gmail.com
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Modules/_ctypes/callproc.c View 1 chunk +28 lines, -9 lines 1 comment Download

Messages

Total messages: 1
storchaka
2 years, 7 months ago #1
LGTM except small style nit.

http://bugs.python.org/review/27963/diff/18351/Modules/_ctypes/callproc.c
File Modules/_ctypes/callproc.c (right):

http://bugs.python.org/review/27963/diff/18351/Modules/_ctypes/callproc.c#new...
Modules/_ctypes/callproc.c:1691: char *coding, *mode, *errors, *encoding=NULL;
Needed spaces around "=".
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+