Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1085)

#27945: Various segfaults with dict

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by tehybel
Modified:
5 months ago
Reviewers:
storchaka+cpython
CC:
Georg, rhettinger, larry, christian.heimes, Benjamin Peterson, ned.deily, duaneg_dghda.com, inada.naoki, storchaka, ebarry, tehybel_gmail.com, tim.mitchell.chch_gmail.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Total comments: 2

Patch Set 6 #

Total comments: 4

Patch Set 7 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_dict.py View 1 2 3 4 5 6 1 chunk +81 lines, -0 lines 0 comments Download
Objects/dictobject.c View 1 2 3 4 5 6 16 chunks +57 lines, -16 lines 4 comments Download

Messages

Total messages: 3
storchaka
http://bugs.python.org/review/27945/diff/19210/Objects/dictobject.c File Objects/dictobject.c (right): http://bugs.python.org/review/27945/diff/19210/Objects/dictobject.c#newcode1119 Objects/dictobject.c:1119: if (insertion_resize(mp) < 0) insertion_resize() can execute arbitrary Python ...
11 months ago #1
storchaka
https://bugs.python.org/review/27945/diff/19211/Objects/dictobject.c File Objects/dictobject.c (right): https://bugs.python.org/review/27945/diff/19211/Objects/dictobject.c#newcode1122 Objects/dictobject.c:1122: Py_DECREF(value); All errors cause decrefing value and key. This ...
5 months ago #2
storchaka
5 months ago #3
https://bugs.python.org/review/27945/diff/19172/Lib/test/test_dict.py
File Lib/test/test_dict.py (right):

https://bugs.python.org/review/27945/diff/19172/Lib/test/test_dict.py#newcode709
Lib/test/test_dict.py:709: (0, X()) in d.items()
In 2.7 should be iteritems().

https://bugs.python.org/review/27945/diff/19172/Lib/test/test_dict.py#newcode719
Lib/test/test_dict.py:719: for result in d.items():
And here.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7