Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(85403)

#2786: Names in traceback should have class names, if they're methods

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by smurf
Modified:
2 months, 4 weeks ago
Reviewers:
vadmium+py
CC:
gvanrossum, Nick Coghlan, sasha, AntoinePitrou, rbcollins, ezio.melotti, smurf_smurf.noris.de, arfrever.fta_gmail.com, Martin Panter, storchaka, o11c, ilblackdragon, Steven.Barker, rymg19_gmail.com, xonatius
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Patch Set 3 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Include/eval.h View 1 2 1 chunk +15 lines, -6 lines 1 comment Download
Lib/test/test_extcall.py View 1 2 3 chunks +101 lines, -0 lines 0 comments Download
Lib/test/test_keywordonlyarg.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
Misc/ACKS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
Misc/NEWS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
Objects/funcobject.c View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
PC/python3.def View 1 2 1 chunk +1 line, -0 lines 0 comments Download
Python/bltinmodule.c View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
Python/ceval.c View 1 2 13 chunks +28 lines, -14 lines 0 comments Download

Messages

Total messages: 3
Martin Panter
https://bugs.python.org/review/2786/diff/13830/Lib/test/test_keywordonlyarg.py File Lib/test/test_keywordonlyarg.py (right): https://bugs.python.org/review/2786/diff/13830/Lib/test/test_keywordonlyarg.py#newcode79 Lib/test/test_keywordonlyarg.py:79: expected = "KeywordOnlyArgTestCase.testTooManyPositionalErrorMessage.<locals>.f() takes from 1 to 2 positional ...
4 years ago #1
xonatius
Thanks for feedback! Uploaded new patch. https://bugs.python.org/review/2786/diff/13830/Lib/test/test_keywordonlyarg.py File Lib/test/test_keywordonlyarg.py (right): https://bugs.python.org/review/2786/diff/13830/Lib/test/test_keywordonlyarg.py#newcode79 Lib/test/test_keywordonlyarg.py:79: expected = "KeywordOnlyArgTestCase.testTooManyPositionalErrorMessage.<locals>.f() ...
3 years, 10 months ago #2
Martin Panter
2 months, 4 weeks ago #3
https://bugs.python.org/review/2786/diff/15406/Include/eval.h
File Include/eval.h (right):

https://bugs.python.org/review/2786/diff/15406/Include/eval.h#newcode20
Include/eval.h:20: PyAPI_FUNC(PyObject *) PyEval_EvalCodeEx2(PyObject *co,
FYI in Issue 35259 I found out this sort of declaration should be conditional on
something like

#if !defined(Py_LIMITED_API) || Py_LIMITED_API+0 >= 0x3nn0000

depending on how the function is documented.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+