Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19205)

#27782: Multi-phase extension module initialization, inconsistent exceptions and conflicts between code and PEP

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by angwerzx
Modified:
3 years ago
Reviewers:
ncoghlan
CC:
Nick Coghlan, encukou, devnull_psf.upfronthosting.co.za, xiang.zhang
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/c-api/module.rst View 1 chunk +1 line, -1 line 0 comments Download
Include/moduleobject.h View 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_importlib/extension/test_loader.py View 1 chunk +9 lines, -0 lines 0 comments Download
Modules/_testmultiphase.c View 3 chunks +32 lines, -1 line 0 comments Download
Objects/moduleobject.c View 5 chunks +37 lines, -32 lines 1 comment Download

Messages

Total messages: 1
Nick Coghlan
3 years ago #1
This looks good to me, so I'm going to go ahead and add the relevant NEWS
entries and merge it.

http://bugs.python.org/review/27782/diff/18157/Objects/moduleobject.c
File Objects/moduleobject.c (right):

http://bugs.python.org/review/27782/diff/18157/Objects/moduleobject.c#newcode421
Objects/moduleobject.c:421: return -1;
We'll want braces here, but I can add those before committing.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+