Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(169614)

#27779: Sync-up docstrings in C version of the the decimal module

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 3 months ago by raymond.hettinger
Modified:
2 years, 8 months ago
Reviewers:
stefan, lisaroach14
CC:
rhettinger, skrah, docs_python.org, lisroach
Visibility:
Public.

Patch Set 1 #

Total comments: 16

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/_pydecimal.py View 1 22 chunks +118 lines, -44 lines 0 comments Download
Modules/_decimal/docstrings.h View 1 10 chunks +1047 lines, -143 lines 0 comments Download

Messages

Total messages: 4
skrah
http://bugs.python.org/review/27779/diff/18450/Modules/_decimal/docstrings.h File Modules/_decimal/docstrings.h (left): http://bugs.python.org/review/27779/diff/18450/Modules/_decimal/docstrings.h#oldcode34 Modules/_decimal/docstrings.h:34: Return a context manager that will set the default ...
3 years, 1 month ago #1
skrah
http://bugs.python.org/review/27779/diff/18450/Modules/_decimal/docstrings.h File Modules/_decimal/docstrings.h (right): http://bugs.python.org/review/27779/diff/18450/Modules/_decimal/docstrings.h#newcode405 Modules/_decimal/docstrings.h:405: Returns a copy of the operand with the sign ...
3 years, 1 month ago #2
lisroach
Thanks Stefan! I added a couple of notes to your comments, I'll upload the new ...
3 years ago #3
skrah
2 years, 8 months ago #4
https://bugs.python.org/review/27779/diff/18450/Modules/_decimal/docstrings.h
File Modules/_decimal/docstrings.h (right):

https://bugs.python.org/review/27779/diff/18450/Modules/_decimal/docstrings.h...
Modules/_decimal/docstrings.h:244: Represents the number as a triple tuple, to
show the internals exactly as\n\
I meant "show the internals exactly as they are". This is not true for the C
version.

It is not true for the Python version because it uses a string for the
coefficient -- the initial version had the tuple IIRC.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+