Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(152304)

#27778: PEP 524: Add os.getrandom()

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 3 months ago by vstinner
Modified:
3 years, 1 month ago
Reviewers:
ncoghlan, vadmium+py
CC:
Nick Coghlan, haypo, christian.heimes, docs_python.org, devnull_psf.upfronthosting.co.za, Martin Panter
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/os.rst View 1 1 chunk +8 lines, -0 lines 1 comment Download

Messages

Total messages: 4
Nick Coghlan
Implementation looks good to me, just one suggestion to make the non-blocking test case a ...
3 years, 3 months ago #1
victor.stinner_gmail.com
https://bugs.python.org/review/27778/diff/18151/Lib/test/test_os.py File Lib/test/test_os.py (right): https://bugs.python.org/review/27778/diff/18151/Lib/test/test_os.py#newcode1270 Lib/test/test_os.py:1270: # The call must not fail. Check also that ...
3 years, 3 months ago #2
Nick Coghlan
https://bugs.python.org/review/27778/diff/18151/Lib/test/test_os.py File Lib/test/test_os.py (right): https://bugs.python.org/review/27778/diff/18151/Lib/test/test_os.py#newcode1267 Lib/test/test_os.py:1267: # resource /dev/random Re-reviewing this, I think it's fine ...
3 years, 3 months ago #3
Martin Panter
3 years, 1 month ago #4
http://bugs.python.org/review/27778/diff/18625/Doc/library/os.rst
File Doc/library/os.rst (right):

http://bugs.python.org/review/27778/diff/18625/Doc/library/os.rst#newcode3957
Doc/library/os.rst:3957: :data:`errno.ENOSYS`` if the Linux kernel does not
support the
Double back-tick should probably be single. Same ffor EPERM below.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+