Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(86341)

#27704: bytes(x) is slow when x is bytearray (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years ago by songofacandy
Modified:
2 years, 7 months ago
Reviewers:
stephane, storchaka+cpython
CC:
haypo, inada.naoki, devnull_psf.upfronthosting.co.za, storchaka, matrixise
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Objects/bytearrayobject.c View 1 1 chunk +15 lines, -15 lines 0 comments Download
Objects/bytesobject.c View 1 1 chunk +13 lines, -13 lines 1 comment Download

Messages

Total messages: 4
matrixise
the patch seems to be fine.
3 years ago #1
storchaka
http://bugs.python.org/review/27704/diff/18085/Objects/bytesobject.c File Objects/bytesobject.c (right): http://bugs.python.org/review/27704/diff/18085/Objects/bytesobject.c#newcode2569 Objects/bytesobject.c:2569: if (PyErr_ExceptionMatches(PyExc_OverflowError)) I think an exception can be raised ...
3 years ago #2
inada.naoki
http://bugs.python.org/review/27704/diff/18085/Objects/bytesobject.c File Objects/bytesobject.c (right): http://bugs.python.org/review/27704/diff/18085/Objects/bytesobject.c#newcode2569 Objects/bytesobject.c:2569: if (PyErr_ExceptionMatches(PyExc_OverflowError)) On 2016/08/09 15:47:31, storchaka wrote: > I ...
3 years ago #3
inada.naoki
2 years, 7 months ago #4
http://bugs.python.org/review/27704/diff/18101/Objects/bytesobject.c
File Objects/bytesobject.c (left):

http://bugs.python.org/review/27704/diff/18101/Objects/bytesobject.c#oldcode2570
Objects/bytesobject.c:2570: PyErr_Clear();
This fall through was required. #29159
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+